make id available since that's expected

anthony-chaudhary · anthony-chaudhary · commit ecdadc4acd63 · 2022-07-20T14:52:29.000-07:00
having the .directory_id is just a legacy thing as far as I know
I don't see any harm in having both and it's more friendly to new person / logical to just do .id
diff --git a/sdk/diffgram/core/directory.py b/sdk/diffgram/core/directory.py
@@ -70,6 +70,8 @@ def convert_json_to_sdk_object(self, directory_list_json):
             )
             refresh_from_dict(new_directory, directory_json)
 
+            new_directory.id = new_directory.directory_id
+
             # note timing issue, this needs to happen after id is refreshed
             new_directory.init_files()
             new_directory.start_iterator(

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,8 @@ def convert_json_to_sdk_object(self, directory_list_json):`
`70`	`70`	`)`
`71`	`71`	`refresh_from_dict(new_directory, directory_json)`
`72`	`72`
	`73`	`+ new_directory.id = new_directory.directory_id`
	`74`	`+`
`73`	`75`	`# note timing issue, this needs to happen after id is refreshed`
`74`	`76`	`new_directory.init_files()`
`75`	`77`	`new_directory.start_iterator(`