-
Notifications
You must be signed in to change notification settings - Fork 47
Some examples can't be compiled by mm0-rs #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| /// Elaborate a file, and return the completed [`FrozenEnv`] result, along with the | ||
| /// file contents. | ||
| pub(crate) fn elab_for_result(path: FileRef) -> io::Result<(FileContents, Option<FrozenEnv>)> { | ||
| pub fn elab_for_result(path: FileRef) -> io::Result<(FileContents, Option<FrozenEnv>)> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make this pub in order to make it accessible from the test. Unfortunately this results in a bunch of warnings about missing documentation.
|
Hm, not sure exactly how to handle this. Some of the examples are known to fail, but I agree it's not a good look. (The list of files in the CI are the only ones which are really important, but of course the others can function as test cases.) It's closer to a playground folder than a curated collection of test cases. Some of these do appear to be actual bugs though.
|
|
Is there an active example that does use mm0-rs compile with a main function? I'm not clear in the hello_mmc it seems like main is empty and the verifier.mm1 the main appears to be potentially out of date? |
|
@Downchuck |
While browsing the examples, I noticed that some of them don't seem to compile with mm0-rs:
I'm attaching a failing integration test for mm0-rs, which tries to elaborate all of the example files. I'm not sure if this is the best way to go about it, or even a good idea at all, but perhaps you find it useful.
Here's the errors I'm getting:
examples/hello_assembler.mm1examples/lean.mm1examples/string.mm0examples/verifier.mm1