Increase timeout for adding a project after accepting an invite?

[achou11]

Currently there are a couple of hardcoded timeouts that are used for determining how long we're willing to wait for the steps after an invite is accepted to complete.

As noted in some early testing on mobile that I've done (digidem/comapeo-mobile#1080 (comment)), I'm consistently running into the timeout related to adding a project (on my Pixel 2): [TimeoutError: Timed out adding project]

Of course the best solution would be to identify why it takes so long to begin with. However, given the various factors that could affect this, I'm wondering if it would be helpful to expose a timeout option for the InviteApi.accept() method so that the consuming application can have some flexibility for configuring it based on context. EDIT: after discussion, we concluded that it would be preferred to decide on a more generous timeout that's still hardcoded in core.

[achou11]

Hm seems to also be happening when my newer + more powerful device (Pixel 6) is the invitee. Maybe the underlying issue of why it's taking so long is the real issue that should be reported?

[RangerMauve]

IS there a way to get a stack trace from that error?

[achou11]

IS there a way to get a stack trace from that error?

Can try to get you one tomorrow!

[achou11]

@RangerMauve line numbers aren't going to be helpful since it's from a bundled file, but here's the stacktrace:

TimeoutError: Timed out adding project
    at error (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:180811:30)
    at Function.resolveAssign [as resolve] (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:179935:67)
    at resolveAndExecuteActionsWithContext (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:179355:56)
    at resolveActionsAndContext (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:179378:21)
    at microstep (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:179111:15)
    at macrostep (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:179434:20)
    at StateMachine.transition (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:180405:12)
    at Actor._process (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:178090:30)
    at Mailbox.flush (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:177278:12)
    at Mailbox.enqueue (file:///data/data/com.comapeo.dev/files/nodejs-project/index.js:177270:12)

[achou11]

If I had to guess, waiting for the initial sync when the invitee adds the project is taking a very long time.

[achou11]

this is the last sync state received by the invitee before getting the timeout error (logged via this line):

{
    auth: {
      dataToSync: false,
      coreCount: 3,
      localState: {want: 0, have: 5, wanted: 0},
      remoteStates: {a73a3cf: {have: 5, want: 0, wanted: 0, status: 'started'}},
    },
    config: {
      dataToSync: false,
      coreCount: 3,
      localState: {want: 0, have: 1174, wanted: 0},
      remoteStates: {
        a73a3cf: {have: 1174, want: 0, wanted: 0, status: 'started'},
      },
    },
    data: {
      dataToSync: false,
      coreCount: 1,
      localState: {want: 0, have: 0, wanted: 0},
      remoteStates: {a73a3cf: {have: 0, want: 0, wanted: 0, status: 'stopped'}},
    },
    blobIndex: {
      dataToSync: false,
      coreCount: 3,
      localState: {want: 0, have: 0, wanted: 0},
      remoteStates: {a73a3cf: {have: 0, want: 0, wanted: 0, status: 'started'}},
    },
    blob: {
      dataToSync: false,
      coreCount: 1,
      localState: {want: 0, have: 0, wanted: 0},
      remoteStates: {a73a3cf: {have: 0, want: 0, wanted: 0, status: 'stopped'}},
    },
}

[achou11]

@RangerMauve as discussed, I updated the issue title and description to align with the preference of updating the timeout value as opposed to making it configurable