Add browser test for endpoint without CORS.

davidlehn · davidlehn · commit c702f98e838c · 2023-04-28T20:03:10.000-04:00
diff --git a/tests/10-client-api.spec.common.cjs b/tests/10-client-api.spec.common.cjs
@@ -153,6 +153,27 @@ describe('http-client API', () => {
     }
   });
 
+  if(!isNode) {
+    // browser check for endpoint without CORS
+    it.only('handles a CORS error', async () => {
+      let err;
+      let response;
+      const url = `http://${httpHost}/nocors`;
+      try {
+        response = await httpClient.get(url);
+      } catch(e) {
+        err = e;
+      }
+      should.not.exist(response);
+      should.exist(err);
+      err.message.should.equal(
+        `Failed to fetch "${url}". Possible CORS error.`);
+      should.not.exist(err.response);
+      should.exist(err.requestUrl);
+      err.requestUrl.should.equal(url);
+    });
+  }
+
   it('handles a TimeoutError error', async () => {
     let err;
     let response;
diff --git a/tests/utils.cjs b/tests/utils.cjs
@@ -62,50 +62,54 @@ api.makeAgent = options => {
 function createApp() {
   const app = express();
 
-  app.use(cors());
-
-  app.get('/ping', (req, res) => {
+  app.get('/ping', cors(), (req, res) => {
     res.json({
       pong: true
     });
   });
 
-  app.get('/json', (req, res) => {
+  app.get('/json', cors(), (req, res) => {
     res.json({
       json: true
     });
   });
 
-  app.get('/html', (req, res) => {
+  app.get('/html', cors(), (req, res) => {
     res.setHeader('Content-Type', 'text/html');
     res.send(
       '<!DOCTYPE html><html><head></head><body><p>HTML</p></body></html>'
     );
   });
 
   // emulate http://httpbin.org/status/404
-  app.get('/status/404', (req, res) => {
+  app.get('/status/404', cors(), (req, res) => {
     res.status(404).send('NOT FOUND');
   });
 
   // emulate https://httpstat.us/404
-  app.get('/404', (req, res) => {
+  app.get('/404', cors(), (req, res) => {
     res.status(404).json({
       code: 404,
       description: 'Not Found'
     });
   });
 
-  app.get('/delay/:seconds', async (req, res) => {
+  app.get('/delay/:seconds', cors(), async (req, res) => {
     await delay(req.params.seconds * 1000);
     res.status(200).send();
   });
 
-  app.get('/headers', (req, res) => {
+  app.get('/headers', cors(), (req, res) => {
     res.json({
       headers: req.headers
     });
   });
 
+  app.get('/nocors', (req, res) => {
+    res.json({
+      cors: false
+    });
+  });
+
   return app;
 }
