You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please make sure the graphql-eslint version under package.json matches yours.
2. A failing test has been provided
3. A local solution has been provided
4. A pull request is pending review
Describe the bug
When running on windows, the comparison done between the import absolute path and the available fragments paths is incorrect.
The fragmentsFromSiblings returned from siblings.getFragment(fragmentName) is in the format: C:/path/to/file/fragment.graphql
While the calculated absolute path of the import in C:\path\to\file\fragment.graphql
Therefore, this comparison always fails.
source.filePath===importPath
A possible fix can be converting the source.filePath (in 2 places):
path.resolve(source.filePath)===importPath
I will try to open a PR to fix this.
Not sure how to add a test though...
To Reproduce Steps to reproduce the behavior:
Expected behavior
Environment:
OS: Windows
@graphql-eslint/eslint-plugin: 3.20.1
Node.js: 18.20.2 (not relevant)
Additional context
The text was updated successfully, but these errors were encountered:
An alternative would be to change the filePath formatting in the getFragments function itself, but I'm not sure what would be affected by such a change
Issue workflow progress
Progress of the issue based on the
Contributor Workflow
1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox
2. A failing test has been provided
3. A local solution has been provided
4. A pull request is pending review
Describe the bug
When running on windows, the comparison done between the import absolute path and the available fragments paths is incorrect.
The
fragmentsFromSiblings
returned fromsiblings.getFragment(fragmentName)
is in the format:C:/path/to/file/fragment.graphql
While the calculated absolute path of the import in
C:\path\to\file\fragment.graphql
Therefore, this comparison always fails.
A possible fix can be converting the source.filePath (in 2 places):
I will try to open a PR to fix this.
Not sure how to add a test though...
To Reproduce Steps to reproduce the behavior:
Expected behavior
Environment:
@graphql-eslint/eslint-plugin
: 3.20.1Additional context
The text was updated successfully, but these errors were encountered: