Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability in transitive dependencies #2423

Open
4 tasks
tapegram opened this issue Jun 27, 2024 · 5 comments
Open
4 tasks

Security vulnerability in transitive dependencies #2423

tapegram opened this issue Jun 27, 2024 · 5 comments

Comments

@tapegram
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    For example, you can start off by editng the
    'basic' example on Stackblitz.

    Please make sure the graphql-eslint version under package.json matches yours.

  • 2. A failing test has been provided

  • 3. A local solution has been provided

  • 4. A pull request is pending review


Describe the bug

Dependabot is reporting a transitive dependency needs updating:

Screenshot 2024-06-27 at 2 19 32 PM

It would be great if graphql-eslint could update its dependencies on graphql-tools once they release their updates.

They updated their version of ws in the last week:

ardatan/graphql-tools#6273

image

To Reproduce Steps to reproduce the behavior:

Expected behavior

No more vulnerability in transitive dependencies!

Thanks!

@bxt
Copy link

bxt commented Jun 28, 2024

It seems the a recent version (>5) of graphql-config does not have this dependency chain anymore, and it was already updated in 296f700 so a fresh release of @graphql-eslint/eslint-plugin would already resolve the issue, I think.

@alimony
Copy link

alimony commented Jul 1, 2024

@dimaMachina What are the plans for a new release? The last release was almost a year ago.

@Lukeaber
Copy link

@dimaMachina @dotansimha Also seeing this issue also through npm, is it possible to get a release?

@lucasrmendonca
Copy link

Hi @comatory @dimaMachina, any plans for a new release to fix security vulnerabilities?

@EduardodaVeiga
Copy link

For the ones that needs it fixed without waiting for a new release, you can override the graphql-config version in the package.json since they have already fixed the issue. This will make the audit errors go away.

For yarn just add this to package.json :
"resolutions": { "@graphql-eslint/eslint-plugin/graphql-config": "5.0.0" }

For npm:
"overrides": { "@graphql-eslint/eslint-plugin": { "graphql-config": "5.0.0" } }

You will still get a warn saying the versions are incompatible, but the errors go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants