Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated cl by cl-lib #2792

Closed
stephan-cr opened this issue Dec 28, 2020 · 3 comments
Closed

Replace deprecated cl by cl-lib #2792

stephan-cr opened this issue Dec 28, 2020 · 3 comments

Comments

@stephan-cr
Copy link
Contributor

Since Emacs 27, the package cl is deprecated (and issues a warning: Package cl is deprecated). The replacement for cl is cl-lib.

I would like to provide a PR which ports all el-get code to use cl-lib, instead of cl. For this, it would be best to drop support for Emacs versions less than 24.3, because since Emacs 24.3, cl-lib is builtin and doesn't need an extra package from ELPA.

What do you think, can I go ahead?

@yyr
Copy link
Collaborator

yyr commented Dec 31, 2020

I think its reasonable to drop support for <24.3. its almost 8 years passed since 24.2 is released. I still come across earlier versions of emacs on some linux servers that I use, but again with so many incompatibilities, now a days I tend to install latest version of emacs in home directory on those servers.

So yes, I support such change.

@thoni56
Copy link
Contributor

thoni56 commented Mar 21, 2021

As Emacs now issues a deprecation warning, it is time ;-)

I tried just simple-minded replace all (require 'cl) with (require 'cl-lib) which seems to be the prefered replacement, but the tests did not run with that change...

EDIT: I missed the PR, thanks @stephan-cr

@stephan-cr
Copy link
Contributor Author

PR has been merged, therefore, it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants