Wire WITH on error stop load-file option to copy/*on-error-stop* in v4

The WITH on error stop / on error resume next options were already
parsed by the grammar and surfaced as :on-error-stop in with-options
by ast.clj, but run-command in core.clj never read them.  Only the
--on-error-stop CLI flag set copy/*on-error-stop*.

Fix: extract :on-error-stop from with-options and add it to the
binding block alongside batch-rows, batch-size, etc.  Use (some? v)
instead of (or v ...) since the option is boolean: a false value from
a future explicit on-error-resume path must not be ignored.

Add parser tests verifying that:
- WITH on error stop  → :on-error-stop true  in with-options
- WITH on error resume next → :on-error-stop absent from with-options

Author: dimitri

clojure/src/pgloader/core.clj

@@ -454,11 +454,13 @@
               opts-batch-size    (some-> (get (:with-options cmd) :batch-size) (Long/parseLong))
               opts-prefetch-rows (some-> (get (:with-options cmd) :prefetch-rows) (long))
               opts-batch-concurr (some-> (get (:with-options cmd) :batch-concurrency) (long))
+              opts-on-error-stop (get (:with-options cmd) :on-error-stop)
               _ (when (and opts-prefetch-rows opts-batch-concurr)
                   (throw (ex-info "pgloader: 'batch concurrency' (deprecated) and 'prefetch rows' cannot both appear in the same WITH clause; remove 'batch concurrency'" {})))]
           (binding [copy/*batch-rows* (or opts-batch-rows copy/*batch-rows*)
                     copy/*batch-size* (or opts-batch-size copy/*batch-size*)
-                    copy/*prefetch-queue-capacity* (or opts-prefetch-rows opts-batch-concurr copy/*prefetch-queue-capacity*)]
+                    copy/*prefetch-queue-capacity* (or opts-prefetch-rows opts-batch-concurr copy/*prefetch-queue-capacity*)
+                    copy/*on-error-stop* (if (some? opts-on-error-stop) opts-on-error-stop copy/*on-error-stop*)]
             (try
           ;; Send MySQL-specific SET params to the MySQL source connection before catalog fetch
               (when (#{:mysql :mariadb} (:type source-uri))

clojure/test/pgloader/load_file/parser_test.clj

@@ -552,3 +552,20 @@
                    WITH downcase identifiers;")]
       (is (:ok result) (str "Parse failed: " (:error result)))
       (is (true? (get-in result [:ok :with-options :downcase-ids]))))))
+
+(deftest test-with-on-error-stop
+  (testing "WITH on error stop sets :on-error-stop true in with-options"
+    (let [result (parser/parse-string
+                  "LOAD DATABASE FROM sqlite:///tmp/foo.db
+                   INTO postgresql:///target
+                   WITH on error stop;")]
+      (is (:ok result) (str "Parse failed: " (:error result)))
+      (is (true? (get-in result [:ok :with-options :on-error-stop])))))
+
+  (testing "WITH on error resume next does not set :on-error-stop"
+    (let [result (parser/parse-string
+                  "LOAD DATABASE FROM sqlite:///tmp/foo.db
+                   INTO postgresql:///target
+                   WITH on error resume next;")]
+      (is (:ok result) (str "Parse failed: " (:error result)))
+      (is (nil? (get-in result [:ok :with-options :on-error-stop]))))))