Upgrade black to 24.3.0 (#3618)

Recommended by dependabot due to a CVE (which doesn't really affect us). On
the whole, the changes caused by this new version seem trivial and innocuous
(like adding blank lines after file docstrings) or minor improvements in
readability (the new wrapping of compound dict references and broken ternary
expressions).

This supercedes dependabot's #3453.

Author: dbutenhof

contrib/analysis/sos_collection.py

@@ -333,10 +333,10 @@ def sync_process_sos(self, combined_data: dict):
                     else:
                         self.seen_sos_valid[sosreport] = extracted_sos_data
                 else:
-                    combined_data["sosreports"][sosreport][
-                        "extracted_sos"
-                    ] = self.seen_sos_invalid[sosreport]
+                    combined_data["sosreports"][sosreport]["extracted_sos"] = (
+                        self.seen_sos_invalid[sosreport]
+                    )
             else:
-                combined_data["sosreports"][sosreport][
-                    "extracted_sos"
-                ] = self.seen_sos_valid[sosreport]
+                combined_data["sosreports"][sosreport]["extracted_sos"] = (
+                    self.seen_sos_valid[sosreport]
+                )

lib/pbench/__init__.py

@@ -32,7 +32,7 @@ def __init__(self, cfg_name):
                 try:
                     self.logger_host = self._conf.get("logging", "logger_host")
                     self.logger_port = self._conf.get("logging", "logger_port")
-                except (NoOptionError) as exc:
+                except NoOptionError as exc:
                     raise BadConfig(str(exc))
 
         try:

lib/pbench/agent/redis_utils.py

@@ -1,5 +1,6 @@
 """Redis Convenience classes
 """
+
 import json
 import logging
 import time

lib/pbench/agent/tool_meister.py

@@ -1779,9 +1779,7 @@ def sysinfo(self, data: Dict[str, str]) -> int:
         self._send_client_status(
             "success"
             if failures == 0
-            else f"{failures} failures sending sysinfo data"
-            if not msg
-            else msg
+            else f"{failures} failures sending sysinfo data" if not msg else msg
         )
 
         return failures

lib/pbench/agent/tool_meister_start.py

@@ -1105,9 +1105,11 @@ def start(_prog: str, cli_params: Namespace) -> int:
             tm = dict(
                 benchmark_run_dir=str(benchmark_run_dir),
                 channel_prefix=cli_tm_channel_prefix,
-                tds_hostname=params["origin_host"]
-                if "origin_host" in params
-                else tool_data_sink.host,
+                tds_hostname=(
+                    params["origin_host"]
+                    if "origin_host" in params
+                    else tool_data_sink.host
+                ),
                 tds_port=tool_data_sink.port,
                 controller=full_hostname,
                 tool_group=tool_group.name,

lib/pbench/agent/toolmetadata.py

@@ -2,6 +2,7 @@
 
 Classes for working with and manipulating the tool-scripts/meta.json file.
 """
+
 import json
 
 

lib/pbench/cli/agent/commands/results/clear.py

@@ -1,6 +1,7 @@
 """
 pbench-clear-results
 """
+
 import shutil
 import sys
 

lib/pbench/cli/agent/commands/triggers/list.py

@@ -5,6 +5,7 @@
 triggers from a specific group.
 
 """
+
 import sys
 
 import click

lib/pbench/cli/agent/commands/triggers/register.py

@@ -10,6 +10,7 @@
 directory.
 
 """
+
 import logging
 import sys
 

lib/pbench/common/configtools.py

@@ -1,4 +1,5 @@
 """ Configtools """
+
 from __future__ import print_function
 
 # python3
@@ -34,9 +35,11 @@ def file_list(root):
     rootdir = os.path.dirname(root)
     flist = [root]
     dirlist = [
-        os.path.abspath("%s/%s" % (rootdir, x))
-        if not os.path.isabs(x)
-        else os.path.abspath(x)
+        (
+            os.path.abspath("%s/%s" % (rootdir, x))
+            if not os.path.isabs(x)
+            else os.path.abspath(x)
+        )
         for x in dirlist
     ]
     # insert the directory of the root file at the beginning
@@ -221,7 +224,7 @@ def main(conf, args, opts, files):
                     print("[%s]" % sec)
                     items = conf.items(sec)
                     items.sort()
-                    for (n, v) in items:
+                    for n, v in items:
                         print("%s = %s" % (n, v))
                     print()
             return 0