Skip to content

Commit 35979ee

Browse files
committed
Refactor to remove XMLUtils.getDocumentBuilder
1 parent b352c0a commit 35979ee

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/main/java/org/dita/index/IndexPreprocessor.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ RELIANCE, OR CONSEQUENTIAL DAMAGES (INCLUDING BUT NOT LIMITED TO LOSS OF
3535
import static org.dita.dost.util.Constants.*;
3636

3737
import java.util.*;
38-
import javax.xml.parsers.DocumentBuilder;
3938
import org.dita.dost.log.DITAOTLogger;
4039
import org.dita.dost.util.XMLUtils;
4140
import org.dita.index.configuration.IndexConfiguration;
@@ -101,8 +100,7 @@ public void setLogger(final DITAOTLogger logger) {
101100
* @return read index terms
102101
*/
103102
IndexPreprocessResult process(final Document input) {
104-
final DocumentBuilder documentBuilder = XMLUtils.getDocumentBuilder();
105-
final Document doc = documentBuilder.newDocument();
103+
final Document doc = input.getImplementation().createDocument(null, null, null);
106104
final Node rootElement = input.getDocumentElement();
107105
final List<IndexEntry> indexes = new ArrayList<>();
108106
final Node node = processCurrNode(rootElement, doc, indexes::add).get(0);

src/main/java/org/dita/index/IndexPreprocessorTask.java

+6-4
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ RELIANCE, OR CONSEQUENTIAL DAMAGES (INCLUDING BUT NOT LIMITED TO LOSS OF
3838
import java.util.Collection;
3939
import java.util.Locale;
4040
import javax.xml.parsers.DocumentBuilder;
41+
import javax.xml.parsers.DocumentBuilderFactory;
42+
import javax.xml.parsers.ParserConfigurationException;
4143
import javax.xml.transform.OutputKeys;
4244
import javax.xml.transform.Transformer;
4345
import javax.xml.transform.TransformerFactory;
@@ -47,7 +49,6 @@ RELIANCE, OR CONSEQUENTIAL DAMAGES (INCLUDING BUT NOT LIMITED TO LOSS OF
4749
import org.apache.tools.ant.Project;
4850
import org.apache.tools.ant.Task;
4951
import org.dita.dost.log.DITAOTAntLogger;
50-
import org.dita.dost.util.XMLUtils;
5152
import org.dita.index.configuration.IndexConfiguration;
5253
import org.dita.index.configuration.ParseException;
5354
import org.w3c.dom.Document;
@@ -71,12 +72,13 @@ public class IndexPreprocessorTask extends Task {
7172
public void execute() throws BuildException {
7273
checkParameters();
7374

74-
final DocumentBuilder documentBuilder = XMLUtils.getDocumentBuilder();
75-
7675
final Document doc;
7776
try {
77+
final DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
78+
factory.setNamespaceAware(true);
79+
final DocumentBuilder documentBuilder = factory.newDocumentBuilder();
7880
doc = documentBuilder.parse(input);
79-
} catch (SAXException | IOException e) {
81+
} catch (SAXException | IOException | ParserConfigurationException e) {
8082
throw new BuildException(e);
8183
}
8284

0 commit comments

Comments
 (0)