PR #100 adds AWS KMS support behind the aws feature, including feature-gated tests in core/src/encryption/aws_key_manager.rs.
Current CI coverage:
cargo test --workspace --verbose runs default-feature tests only.cargo clippy --workspace --all-targets --all-features compiles the AWS code path, but does not execute tests.
Gap:
- Feature-gated AWS KMS tests are not explicitly executed in CI.
Requested follow-up:
- Add explicit CI coverage for the AWS feature path, for example with targeted commands such as:
cargo test -p keycast_core --features aws --lib --verbosecargo test -p keycast --features aws --lib --verbose (or equivalent no-run/targeted coverage if full runtime tests are too heavy)
- Ensure the PR workflow continues to validate both default and aws-enabled builds.
Relevant files:
.github/workflows/build-test-push.yamlcore/src/encryption/aws_key_manager.rskeycast/src/main.rs
This is non-blocking for PR #100 because the code compiles cleanly, clippy passes with all features, and the full PR checks are green, but the CI coverage should be tightened.
PR #100 adds AWS KMS support behind the
awsfeature, including feature-gated tests incore/src/encryption/aws_key_manager.rs.Current CI coverage:
cargo test --workspace --verboseruns default-feature tests only.cargo clippy --workspace --all-targets --all-featurescompiles the AWS code path, but does not execute tests.Gap:
Requested follow-up:
cargo test -p keycast_core --features aws --lib --verbosecargo test -p keycast --features aws --lib --verbose(or equivalent no-run/targeted coverage if full runtime tests are too heavy)Relevant files:
.github/workflows/build-test-push.yamlcore/src/encryption/aws_key_manager.rskeycast/src/main.rsThis is non-blocking for PR #100 because the code compiles cleanly, clippy passes with all features, and the full PR checks are green, but the CI coverage should be tightened.