This repository has been archived by the owner on Feb 20, 2024. It is now read-only.
Use vendor path to phpunit #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Nov 30, 2018
| @@ -9,7 +9,7 @@ php: | |||
|
|
|||
| before_script: composer install --prefer-source | |||
|
|
|||
| script: phpunit --debug --coverage-text | |||
| script: vendor/phpunit/phpunit/phpunit | |||
There was a problem hiding this comment.
Isnt that one too many phpunit?
I'll see if the tests fails or not.
There was a problem hiding this comment.
vendor, package, bin. It should be correct but phpunit is not imported ¯_(ツ)_/¯
|
Dropped test for 5.* due to memory issue. Don't think it's worth trying to fix.
|
|
Do you guys want to takeover the ownership of the bundle? As I don't maintain it anymore. |
|
I think @Nyholm will be at better maintainer but I can sure step up if he doesn't want to. |
|
@jongotlin I added you as a collaborator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.