Why TranslatedFieldsField assumes there is a parent.Meta.model?

[kemar]

Hi,

I have a question regarding this commit : 5e9cc04

Sometimes we don't inherit from a ModelSerializer, e.g.:

class TemplateSerializer(drf_serializers.Serializer):
    translations = parler_serializers.TranslatedFieldsField(shared_model=models.Template)

The above mentioned commit breaks non-ModelSerializer:

AttributeError: 'FileSerializer' object has no attribute 'Meta'

Is there a valid reason why TranslatedFieldsField assumes there is a parent.Meta.model?

[vdboor]

The TranslatedFieldsField only works on a TranslatableModelSerializer, see the example in the README. Both need to work together, as serialize fields can't control the model .save() call sadly.

I've highlighted this fact in the readme now.

[vdboor]

Sorry, after closing reading I see you're trying to create a "mixin" or base class. I've moved the checks of the parent.Meta.model to the actual place they are used, instead of checking them too early (see 9a3dd7c). Does this work for you?