-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons fail to load #1881
Comments
I can see icons on mobile 👍 I tested the website with Android 15 on Pixel 7. Chrome 132Firefox 134@sarahboyce what version of Phone/OS/Browser are you experiencing the issue? |
Android 14, Chrome 132 |
@sarahboyce Is this reproducible for you? I'm not exactly sure how assets work on production, but I'm assuming this is a one-time, cache-related thing. |
I still have this with cleared cache, it's been this way for a few days |
Is it the same if you try an incognito window or another browser like Firefox? I can't reproduce either 🤔 |
Works on incognito 👍 |
Ah, given your comment in #1887, it seems like a production configuration issue, right? I wonder why it's not happening for the rest of us though. |
Since the discussion seems to be happening here, this is @sarahboyce's comment from #1887 showing the console errors related to this issue:
The asset URL works fine for me. It's odd to me that For what it's worth, this header seems a bit odd to me too, but I should revisit the docs: Anyway, these are just initial ideas. I hope to have some time later this week to debug this if the solution is not obvious to someone else. |
I added a screenshot of the broken link for me and this is cached until Dec 2037. I wonder if @bmispelon can do anything here 🤔 |
This is definitely confusing 🤔 In case that helps, here's the relevant (I think) portion of the nginx configuration for
It seems that the response you're receiving have the wrong |
|
Cleared my cache on firefox, desktop this morning and the error is gone and icons load. I know have the correct Clearing the cache isn't working on mobile, I don't have access to errors to see what is going on there 🤔 |
Ah there's a "filter" on clearing data on mobile to only do the last 24 hours 🤦 |
I think I managed to reproduce the issue consistently with these steps (using Firefox on desktop):
When doing that, the icon that should be in the green box "Always refer to the documentation that corresponds to the version of Django you’re using!" is missing and replaced by a square box with 4 letters. My best understanding of the bug is that the browser is caching the font alongside the |
I wonder if this might be the issue we're seeing: https://stackoverflow.com/questions/44800431/caching-effect-on-cors-no-access-control-allow-origin-header-is-present-on-th If so, the fix suggested in the top answer is to tweak the I'll try that config change later today and see if that helps. |
@bmispelon Good find! Are you getting this on the document response when you go to https://www.djangoproject.com/ ? Does that seem correct? |
🎉 yes, this is it. |
The fix I did with the headers appears to be live (I even cleared the fastly cache), but unfortunately it doesn't seem to have fixed anything 😿 |
Noticed that icons are not loading on djangoproject.com (at least for me: on desktop, firefox, on mobile Chrome, Android).
They work on code.djangoproject.com and docs.djangoproject.com for mobile, they work in incognito mode 👍
Errors:
Screenshots with broken icons
Desktop:
Mobile:
The text was updated successfully, but these errors were encountered: