Skip to content

Commit a8e03d7

Browse files
cpudjc
authored andcommitted
lib: enforce ARI order state includes replaces
The spec says this is a MUST. We temporarily relaxed this requirement while Let's Encrypt fixed a bug with their server-side ARI implementation. Since that bug was fixed, we can go back to matching what the spec says.
1 parent d4067ff commit a8e03d7

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/lib.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -655,11 +655,7 @@ impl Account {
655655
// "If the Server accepts a new-order request with a "replaces" field, it MUST reflect
656656
// that field in the response and in subsequent requests for the corresponding Order
657657
// object."
658-
// In practice, Let's Encrypt staging/production are not properly reflecting this field
659-
// so we enforce it matches only when the server sends it.
660-
// TODO(@cpu): tighten this up once Let's Encrypt is fixed.
661-
if order.replaces.is_some() && state.replaces.is_some() && order.replaces != state.replaces
662-
{
658+
if order.replaces.is_some() && order.replaces != state.replaces {
663659
return Err(Error::Other(
664660
format!(
665661
"replaces field mismatch: expected {expected:?}, found {found:?}",

0 commit comments

Comments
 (0)