Extract and re-use details screen starting code. #589

Author: Gabor Keszthelyi

opentasks/src/main/java/org/dmfs/tasks/EditTaskFragment.java

@@ -54,6 +54,7 @@
 import org.dmfs.tasks.contract.TaskContract;
 import org.dmfs.tasks.contract.TaskContract.TaskLists;
 import org.dmfs.tasks.contract.TaskContract.Tasks;
+import org.dmfs.tasks.detailsscreen.BasicTaskDetailsUi;
 import org.dmfs.tasks.model.CheckListItem;
 import org.dmfs.tasks.model.ContentSet;
 import org.dmfs.tasks.model.Model;
@@ -793,7 +794,7 @@ public void saveAndExit()
                 activity.finish();
                 if (isNewTask)
                 {
-                    activity.startActivity(new Intent("android.intent.action.VIEW", mTaskUri));
+                    new BasicTaskDetailsUi(mTaskUri).show(activity);
                 }
             }
             else

opentasks/src/main/java/org/dmfs/tasks/TaskListActivity.java

@@ -52,6 +52,7 @@
 import org.dmfs.android.retentionmagic.annotations.Retain;
 import org.dmfs.provider.tasks.AuthorityUtil;
 import org.dmfs.tasks.contract.TaskContract.Tasks;
+import org.dmfs.tasks.detailsscreen.BasicTaskDetailsUi;
 import org.dmfs.tasks.groupings.AbstractGroupingFactory;
 import org.dmfs.tasks.groupings.ByDueDate;
 import org.dmfs.tasks.groupings.ByList;
@@ -203,9 +204,7 @@ protected void onCreate(Bundle savedInstanceState)
         {
             if (mShouldShowDetails && mShouldSwitchToDetail)
             {
-                Intent viewTaskIntent = new Intent(Intent.ACTION_VIEW);
-                viewTaskIntent.setData(mSelectedTaskUri);
-                startActivity(viewTaskIntent);
+                new BasicTaskDetailsUi(mSelectedTaskUri).show(this);
                 mSwitchedToDetail = true;
                 mShouldSwitchToDetail = false;
                 mTransientState = true;
@@ -430,9 +429,7 @@ else if (forceReload)
 
                 // In single-pane mode, simply start the detail activity
                 // for the selected item ID.
-                Intent detailIntent = new Intent(Intent.ACTION_VIEW);
-                detailIntent.setData(uri);
-                startActivity(detailIntent);
+                new BasicTaskDetailsUi(uri).show(this);
                 mSwitchedToDetail = true;
                 mShouldSwitchToDetail = false;
             }

opentasks/src/main/java/org/dmfs/tasks/detailsscreen/BasicTaskDetailsUi.java

@@ -0,0 +1,45 @@
+/*
+ * Copyright 2017 dmfs GmbH
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.dmfs.tasks.detailsscreen;
+
+import android.content.Context;
+import android.content.Intent;
+import android.net.Uri;
+
+
+/**
+ * Basic implementation of {@link TaskDetailsUi} that starts an Activity with action VIEW and with the task Uri as data.
+ *
+ * @author Gabor Keszthelyi
+ */
+public final class BasicTaskDetailsUi implements TaskDetailsUi
+{
+    private final Uri mTaskUri;
+
+
+    public BasicTaskDetailsUi(Uri taskUri)
+    {
+        mTaskUri = taskUri;
+    }
+
+
+    @Override
+    public void show(Context context)
+    {
+        context.startActivity(new Intent(Intent.ACTION_VIEW, mTaskUri));
+    }
+}

opentasks/src/main/java/org/dmfs/tasks/detailsscreen/TaskDetailsUi.java

@@ -0,0 +1,33 @@
+/*
+ * Copyright 2017 dmfs GmbH
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.dmfs.tasks.detailsscreen;
+
+import android.content.Context;
+
+
+/**
+ * Represents the task details UI which can be shown.
+ *
+ * @author Gabor Keszthelyi
+ */
+public interface TaskDetailsUi
+{
+    /**
+     * Shows the task details.
+     */
+    void show(Context context);
+}