Add Value MARKs (#228)

* Fix value mark

* Fix special case `value` property

* Add value script

* Add Value MARKs

* Clean up MARK usage

* Fix Mordent DynamicNodeEncoding

* Fix leftovers

* Fix PartSymbol implementation

Author: bwetherfield

Sources/MusicXML/Complex Types/AccidentalText.swift

@@ -24,7 +24,7 @@ public struct AccidentalText {
     public let direction: TextDirection?
     public let enclosure: EnclosureShape?
 
-    // MARK: Elements
+    // MARK: Value
 
     public let value: AccidentalValue
 

Sources/MusicXML/Complex Types/Arrow.swift

@@ -13,7 +13,7 @@ public struct Arrow {
 
     public let kind: Kind
     public let placement: AboveBelow?
-    
+
     // MARK: Attribute Groups
 
     public let position: Position

Sources/MusicXML/Complex Types/BarStyleColor.swift

@@ -9,7 +9,12 @@
 public struct BarStyleColor {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public var value: BarStyle
+
+    // MARK: Attributes
+
     public var color: Color?
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/Barre.swift

@@ -11,6 +11,8 @@
 public struct Barre {
     // MARK: - Instance Properties
 
+    // MARK: Attributes
+
     public let type: StartStop
     public let color: Color
 

Sources/MusicXML/Complex Types/BassAlter.swift

@@ -10,7 +10,12 @@
 public struct BassAlter {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Double
+
+    // MARK: Attributes
+
     public let printObject: Bool?
     public let location: LeftRight?
 

Sources/MusicXML/Complex Types/BassStep.swift

@@ -12,7 +12,12 @@
 public struct BassStep {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Step
+
+    // MARK: Attributes
+
     /// The text attribute indicates how the bass should appear in a score if not using the element
     /// contents.
     public let text: String?

Sources/MusicXML/Complex Types/Beam.swift

@@ -14,6 +14,8 @@
 public struct Beam {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public var value: BeamValue
     public var number: BeamLevel?
     public var repeater: Bool?

Sources/MusicXML/Complex Types/Beater.swift

@@ -8,7 +8,12 @@
 public struct Beater {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: BeaterValue
+
+    // MARK: Attributes
+
     public let tip: TipDirection?
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/Creator.swift

@@ -14,7 +14,7 @@ public struct Creator {
 
     public var value: String
 
-    // MARK: - Attribtues
+    // MARK: - Attributes
 
     public var type: String?
 

Sources/MusicXML/Complex Types/Degree.swift

@@ -27,7 +27,7 @@ public struct Degree {
     // MARK: - Initializers
 
     public init(
-        _ value: DegreeValue,
+        value: DegreeValue,
         alter: DegreeAlter,
         type: DegreeType,
         printObject: Bool? = nil

Sources/MusicXML/Complex Types/DegreeValue.swift

@@ -13,7 +13,12 @@
 public struct DegreeValue {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Int
+
+    // MARK: Attributes
+
     public let symbol: DegreeSymbolValue?
     public let text: String?
 

Sources/MusicXML/Complex Types/Distance.swift

@@ -9,7 +9,12 @@
 public struct Distance {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Tenths
+
+    // MARK: Attributes
+
     public let type: DistanceType
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/Feature.swift

@@ -11,7 +11,12 @@
 public struct Feature {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: String
+
+    // MARK: Attributes
+
     public let type: String?
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/Fingering.swift

@@ -12,7 +12,12 @@
 public struct Fingering {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: String
+
+    // MARK: Attributes
+
     public let substitution: Bool?
     public let alternate: Bool?
     public let placement: AboveBelow?

Sources/MusicXML/Complex Types/FirstFret.swift

@@ -10,7 +10,12 @@
 public struct FirstFret {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Int
+
+    // MARK: Attributes
+
     public let text: String?
     public let location: LeftRight?
 

Sources/MusicXML/Complex Types/Font.swift

@@ -23,7 +23,6 @@ public struct Font {
     // FIXME: Font.family should be `CommaSeparatedText`
     public let family: String?
 
-
     // MARK: Attribute Groups
 
     public let style: FontStyle?

Sources/MusicXML/Complex Types/Fret.swift

@@ -16,8 +16,6 @@ public struct Fret {
 
     // MARK: Attributes
 
-    // MARK: Attributes
-
     public let color: Color?
 
     // MARK: Attribute Groups

Sources/MusicXML/Complex Types/Glissando.swift

@@ -12,7 +12,12 @@
 public struct Glissando {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: String
+
+    // MARK: Attributes
+
     public let type: StartStop
     public let number: Int?
     public let lineType: LineType?

Sources/MusicXML/Complex Types/GroupBarline.swift

@@ -9,7 +9,12 @@
 public struct GroupBarline {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public var value: GroupBarlineValue
+    
+    // MARK: Attributes
+    
     public var color: Color?
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/GroupName.swift

@@ -11,7 +11,12 @@
 public struct GroupName {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: String
+
+    // MARK: Attributes
+
     public let justify: Justify?
 
     // MARK: Attribute Groups

Sources/MusicXML/Complex Types/GroupSymbol.swift

@@ -11,7 +11,12 @@ import XMLCoder
 public struct GroupSymbol {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public var value: GroupSymbolValue
+
+    // MARK: Attributes
+
     public var color: Color?
 
     // MARK: Attribute Groups

Sources/MusicXML/Complex Types/HammerOnPullOff.swift

@@ -13,7 +13,12 @@
 public struct HammerOnPullOff {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: String
+
+    // MARK: Attributes
+
     public let type: StartStop
     public let number: Int?
     public let placement: AboveBelow?

Sources/MusicXML/Complex Types/Handbell.swift

@@ -10,7 +10,12 @@
 public struct Handbell {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: HandbellValue
+
+    // MARK: Attributes
+
     public let placement: AboveBelow?
 
     // MARK: Attribute Groups

Sources/MusicXML/Complex Types/HoleClosed.swift

@@ -9,7 +9,12 @@
 public struct HoleClosed {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: HoleClosedValue
+
+    // MARK: Attributes
+
     /// The optional location attribute indicates which portion of the hole is filled in when the
     /// element value is half.
     public let location: HoleClosedLocation?

Sources/MusicXML/Complex Types/Key.swift

@@ -23,11 +23,11 @@ public struct Key {
 
     public let kind: Kind
     public let keyOctaves: [KeyOctave]
-    
+
     // MARK: Attribute Groups
 
     public let printStyle: PrintStyle
-    
+
     // MARK: - Initializers
 
     public init(number: Int? = nil, printStyle: PrintStyle = PrintStyle(), printObject: Bool? = nil, kind: Kind, keyOctaves: [KeyOctave] = []) {

Sources/MusicXML/Complex Types/LineWidth.swift

@@ -10,7 +10,12 @@
 public struct LineWidth {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: Tenths
+
+    // MARK: Attributes
+
     public let type: LineWidthType
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/MIDIDevice.swift

@@ -13,7 +13,12 @@ import XMLCoder
 public struct MIDIDevice {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public var value: String?
+
+    // MARK: Attributes
+
     /// The optional port attribute is a number from 1 to 16 that can be used with the unofficial
     /// MIDI port (or cable) meta event.
     public var port: Int?

Sources/MusicXML/Complex Types/MeasureNumbering.swift

@@ -10,6 +10,8 @@
 public struct MeasureNumbering {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: MeasureNumberingValue
 
     // MARK: Attribute Groups

Sources/MusicXML/Complex Types/MetronomeBeam.swift

@@ -10,7 +10,12 @@
 public struct MetronomeBeam {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: BeamValue
+
+    // MARK: Attributes
+
     public let number: BeamLevel?
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/MetronomeTuplet.swift

@@ -10,7 +10,12 @@
 public struct MetronomeTuplet {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     public let value: TimeModification
+
+    // MARK: Attributes
+
     public let type: StartStop
     public let bracket: Bool?
     public let showNumber: ShowTuplet?

Sources/MusicXML/Complex Types/Mordent.swift

@@ -41,7 +41,6 @@ extension Mordent: Codable {
         case long
         case approach
         case departure
-        case value = ""
     }
 
     // MARK: Encodable
@@ -68,11 +67,6 @@ extension Mordent: Codable {
 import XMLCoder
 extension Mordent: DynamicNodeEncoding {
     public static func nodeEncoding(for key: CodingKey) -> XMLEncoder.NodeEncoding {
-        switch key {
-        case CodingKeys.value:
-            return .element
-        default:
-            return .attribute
-        }
+        return .attribute
     }
 }

Sources/MusicXML/Complex Types/Notations.swift

@@ -22,6 +22,9 @@ public struct Notations {
 
     public var footnote: FormattedText?
     public var level: Level?
+
+    // MARK: Value
+
     public var values: [Notation]
 
     // MARK: - Initializers

Sources/MusicXML/Complex Types/NoteSize.swift

@@ -14,8 +14,13 @@
 public struct NoteSize {
     // MARK: - Instance Properties
 
+    // MARK: Value
+
     // FIXME: Use `NonNegativeDecimal` if that is wise.
     public let value: Double
+
+    // MARK: Attributes
+
     public let type: NoteSizeType
 
     // MARK: - Initializers