Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release script more robust #832

Open
1 task
timaschew opened this issue May 5, 2019 · 3 comments
Open
1 task

Make release script more robust #832

timaschew opened this issue May 5, 2019 · 3 comments
Labels
needs discussion pinned This is to pinned the PR/Issue in order to keep it open

Comments

@timaschew
Copy link
Member

Bug Report

Steps to reproduce

RELEASE_TAG=next ./build/release.sh

What is current behaviour

docsify-server-renderer was published to npm
but not docsify nor it was pushed to github

What is the expected behaviour

check all packages before publishing
check repository (if fast-forward is possible) before pushing to github or publishing to np,
either all packages should be published/pushed to github or nothing should published/pushed

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

@jrappen
Copy link
Contributor

jrappen commented May 7, 2019

It might help rolling back to the previous use of a mono-repo for development for all repos of the https://github.com/docsifyjs organisation. I found the the creation of separate repos for translations and the cli not helpful with trying to coordinate development of all things docsify related ... but maybe it's me.

Having a look at https://github.com/vuejs/vuepress/blob/master/scripts/release.js might help with the release script here.

@anikethsaha
Copy link
Member

I am +1 for making the release script in more depth.

I was thinking about standard-release but that might change the changelog.

Having a look at https://github.com/vuejs/vuepress/blob/master/scripts/release.js might help with the release script here.

This looks interesting. Maybe we can have this.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion pinned This is to pinned the PR/Issue in order to keep it open
Projects
None yet
Development

No branches or pull requests

4 participants