rest of feedback

James Cor · James Cor · commit 6e545dba1bce · 2025-10-31T14:25:05.000-07:00
diff --git a/sql/expression/comparison_test.go b/sql/expression/comparison_test.go
@@ -220,7 +220,7 @@ func TestGreaterThan(t *testing.T) {
 }
 
 func TestValueComparison(t *testing.T) {
-	// TODO
+	t.Skip("TODO: write tests for comparison between sql.Values")
 }
 
 // BenchmarkComparison
diff --git a/sql/plan/indexed_table_access.go b/sql/plan/indexed_table_access.go
@@ -307,7 +307,7 @@ func (i *IndexedTableAccess) GetLookup(ctx *sql.Context, row sql.Row) (sql.Index
 	return i.lb.GetLookup(ctx, key)
 }
 
-func (i *IndexedTableAccess) getLookup2(ctx *sql.Context, row sql.ValueRow) (sql.IndexLookup, error) {
+func (i *IndexedTableAccess) getValueLookup(ctx *sql.Context, row sql.ValueRow) (sql.IndexLookup, error) {
 	// if the lookup was provided at analysis time (static evaluation), use it.
 	if !i.lookup.IsEmpty() {
 		return i.lookup, nil

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ func TestGreaterThan(t *testing.T) {`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`func TestValueComparison(t *testing.T) {`
`223`		`- // TODO`
	`223`	`+ t.Skip("TODO: write tests for comparison between sql.Values")`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`// BenchmarkComparison`
Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ func (i IndexedTableAccess) GetLookup(ctx sql.Context, row sql.Row) (sql.Index`
`307`	`307`	`return i.lb.GetLookup(ctx, key)`
`308`	`308`	`}`
`309`	`309`
`310`		`-func (i IndexedTableAccess) getLookup2(ctx sql.Context, row sql.ValueRow) (sql.IndexLookup, error) {`
	`310`	`+func (i IndexedTableAccess) getValueLookup(ctx sql.Context, row sql.ValueRow) (sql.IndexLookup, error) {`
`311`	`311`	`// if the lookup was provided at analysis time (static evaluation), use it.`
`312`	`312`	`if !i.lookup.IsEmpty() {`
`313`	`313`	`return i.lookup, nil`