Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming: mk_url! vs safe! #8

Open
3 tasks
cognivore opened this issue Jan 14, 2023 · 0 comments
Open
3 tasks

Confusing naming: mk_url! vs safe! #8

cognivore opened this issue Jan 14, 2023 · 0 comments

Comments

@cognivore
Copy link
Contributor

Why?

mk_* functions that encode binary() were written first without consideration of the Binary-based constructor.
Binary-based constructor is called safe!.
It's rather hard to figure out which function to call depending on what is the data format we're working with.

How?

  • Rename mk_* functions into *_from_raw*.
  • Delegate r2* shorthands.
  • Delegate mk_* shorthands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant