You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, vents seem to have wrong typespecs, they only encode the target data type, ignoring the incoming raw data type we decode. This is a bug.
Furthermore, when we decode(decode(x)), we crash. Which is suboptimal, so decode should be made idempotent unless there is something that guarantees that decoded events will never be decoded. In that case, in line with the principle of fail fast, fail loud, decode should NOT be made idempotent, but still should be at least guarded.
Why?
Currently, vents seem to have wrong typespecs, they only encode the target data type, ignoring the incoming raw data type we decode. This is a bug.
Furthermore, when we
decode(decode(x))
, we crash. Which is suboptimal, sodecode
should be made idempotent unless there is something that guarantees that decoded events will never be decoded. In that case, in line with the principle of fail fast, fail loud, decode should NOT be made idempotent, but still should be at least guarded.How?
decode
should be idempotent or if our system guarantees that a decoded event shall never be decoded.decode
function in this commit, but leave the pattern match.The text was updated successfully, but these errors were encountered: