Correctly handle True/False/None in doctools.make_sphinx_links

Author: domdfcoding

domdf_python_tools/doctools.py

@@ -147,8 +147,14 @@ def make_sphinx_links(input_string: str, builtins_list: Optional[Sequence[str]]
 
 	working_string = f"{input_string}"
 
-	for builtin in {x for x in builtins_list if not x.startswith("__") and x != "None"}:
-		working_string = working_string.replace(f"``{builtin}``", f":class:`{builtin}`")
+	for builtin in builtins_list:
+		if builtin.startswith("__"):
+			continue
+
+		if builtin in {"None", "False", "None"}:
+			working_string = working_string.replace(f"``{builtin}``", f":py:obj:`{builtin}`")
+		else:
+			working_string = working_string.replace(f"``{builtin}``", f":class:`{builtin}`")
 
 	return working_string
 

tests/test_doctools.py

@@ -318,15 +318,15 @@ def test_still_callable():
 def test_make_sphinx_links():
 
 	original = """
-		This is a docstring that contains references to ``str``, ``int``, and ``float``
+		This is a docstring that contains references to ``str``, ``int``, ``float`` and ``None``,
 		but lacks proper references to them when rendered in Sphinx.
 
 		:return: pi
 		:rtype: float
 		"""
 
 	sphinx = """
-		This is a docstring that contains references to :class:`str`, :class:`int`, and :class:`float`
+		This is a docstring that contains references to :class:`str`, :class:`int`, :class:`float` and :py:obj:`None`,
 		but lacks proper references to them when rendered in Sphinx.
 
 		:return: pi