diff --git a/examples/karpenter/MIGRATION.md b/examples/karpenter/MIGRATION.md index 4611b502..39e48198 100644 --- a/examples/karpenter/MIGRATION.md +++ b/examples/karpenter/MIGRATION.md @@ -83,7 +83,7 @@ Given that karpenter itself is stateless, we set the `single_nodegroup` in order #### Implementation Steps -1. Add the following to the infra.tfvars and nodes.tfvars: +1. Check if the karpenter_node_groups variable exists then update or add it to the following to the infra.tfvars and nodes.tfvars: ```hcl # Consult the karpenter_node_groups variable for additional options. @@ -95,7 +95,7 @@ karpenter_node_groups = { } ``` -2. Add the following to the cluster.tfvars: +2. Check if the karpenter variable exists then update or add it to the cluster.tfvars: ```hcl # Consult the karpenter variable for additional options. @@ -214,7 +214,8 @@ If you do not wish to use the script to create and apply the `ec2nodeclasses` an 3. Apply the Karpenter configurations: ```bash -./karpenter/karpenter-configs.sh apply +cd karpenter +./karpenter-configs.sh apply ``` diff --git a/examples/karpenter/karpenter-configs.sh b/examples/karpenter/karpenter-configs.sh index fa558026..88e64ba0 100755 --- a/examples/karpenter/karpenter-configs.sh +++ b/examples/karpenter/karpenter-configs.sh @@ -145,6 +145,7 @@ check_directories case "$1" in "render") + render echo "Templates rendered successfully!" ;; "apply") diff --git a/examples/karpenter/templates/nodepools/compute.yaml b/examples/karpenter/templates/nodepools/compute.yaml index 5936d820..967df9ef 100644 --- a/examples/karpenter/templates/nodepools/compute.yaml +++ b/examples/karpenter/templates/nodepools/compute.yaml @@ -14,9 +14,9 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: default spec: - limits: - cpu: 240 - memory: 960Gi +# limits: +# cpu: 240 +# memory: 960Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws diff --git a/examples/karpenter/templates/nodepools/gpu.yaml b/examples/karpenter/templates/nodepools/gpu.yaml index bedb5396..71c27140 100644 --- a/examples/karpenter/templates/nodepools/gpu.yaml +++ b/examples/karpenter/templates/nodepools/gpu.yaml @@ -15,10 +15,10 @@ spec: dominodatalab.com/node-pool: default-gpu nvidia.com/gpu: "true" spec: - limits: - cpu: 80 - memory: 320Gi - nvidia.com/gpu: 10 +# limits: +# cpu: 80 +# memory: 320Gi +# nvidia.com/gpu: 10 expireAfter: Never nodeClassRef: group: karpenter.k8s.aws diff --git a/examples/karpenter/templates/nodepools/neuron.yaml b/examples/karpenter/templates/nodepools/neuron.yaml index fb78ce73..5a94496f 100644 --- a/examples/karpenter/templates/nodepools/neuron.yaml +++ b/examples/karpenter/templates/nodepools/neuron.yaml @@ -15,10 +15,10 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: trainium spec: - limits: - aws.amazon.com/neuron: 10 - cpu: 80 - memory: 320Gi +# limits: +# aws.amazon.com/neuron: 10 +# cpu: 80 +# memory: 320Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws diff --git a/examples/karpenter/templates/nodepools/platform.yaml b/examples/karpenter/templates/nodepools/platform.yaml index 10491ec5..5636e207 100644 --- a/examples/karpenter/templates/nodepools/platform.yaml +++ b/examples/karpenter/templates/nodepools/platform.yaml @@ -14,9 +14,9 @@ spec: dominodatalab.com/domino-node: "true" dominodatalab.com/node-pool: platform spec: - limits: - cpu: 160 - memory: 640Gi +# limits: +# cpu: 160 +# memory: 640Gi expireAfter: Never nodeClassRef: group: karpenter.k8s.aws