-
Notifications
You must be signed in to change notification settings - Fork 35
Do not work, If we pass element as ref #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I prefer the current design but let's see what others say. |
Any update guys? |
I like this. It adds support without breaking existing code. PRs welcome. |
after some thought, what exactly is your use case and why can't you solve this with built-in React |
Hello, Thanks! |
Team, I have the code ready but the test case is giving 90%. Can someone help me. I have attached the test result. Please find the below code that I have added
|
I was in the middle of a rewrite in TypeScript anyway, so I went ahead and added ref support. See #36 Plz try it out (published tp npm as |
check #40 |
Any progress on this? |
If we pass element ref as below
But, It will work If we pass elementRef.current as below
useEventListener('click', () => alert('Ref click'), counterEl.current);
Will suggest a change, and If you allow will create a PR with the following change
The text was updated successfully, but these errors were encountered: