-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise GRNsight people page to match GRNmap layout more closely #872
Comments
I took a stab at updating this page and ran into an older issue that has now come back to haunt us, in a sense—in the very early days of this website, a custom Bootstrap CSS file was put together due to some visual glitches that the full, official Bootstrap CSS apparently manifested on GRNsight. Unfortunately, this full version is necessary in order to implement the carousel. I briefly switched to this full version and the primary visual issue that I noticed was looser spacing on the sidebar menu (see screenshot). Font sizes also appear to be mismatched. There may be other visual issues on other pages but this is the one that popped out immediately. After this switch is made, some adjustments need to be done on the image styling itself (as can also be seen in the screenshot) but at least the core functionality would be there. Because of these side effects, I held back on the big switch but at least adjusted the layout to place the picture at the top with the people listing in two columns in a way that appears to handle variable window widths a little better. So there is that at least. It looks like a full carousel switch will also require whatever adjustments are needed in order to use the full, unmodified Bootstrap CSS. It looks like the GRNmap site was able to make this transition; a similar transition will be needed for GRNsight. |
Purely a website visual issue—will unassign for now and this may perhaps be a better match for a future student to do |
backlog |
This will avoid the minimum-window-width issue that currently pushes the photo off the second column.
The text was updated successfully, but these errors were encountered: