Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectDrivers not disabled for Ivy Bridge generation macs #742

Closed
blahdy opened this issue Nov 17, 2021 · 2 comments
Closed

ConnectDrivers not disabled for Ivy Bridge generation macs #742

blahdy opened this issue Nov 17, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@blahdy
Copy link

blahdy commented Nov 17, 2021

Machine Model

MacBookPro10,1

Application Version

Latest Build (nightly)

Application Variant

GUI (Graphical User Interface)

Have you verified whether this issue has been opened before? If no, your issue will be closed

true

Have you verified whether this issue is covered in our guide? ie. Troubleshooting and Legacy Acceleration pages

true

Is this issue with a 3rd party application?

false

What versions of macOS are you seeing the problem on?

macOS 11, Big Sur

Where does this issue happen?

Within macOS (Before Logging in)

What is the Issue?

ConnectDrivers clearly breaks hibernation on Ivy legacy macs as it was confirmed multiple times in #72 .

It is also reverted upon OC upgrade in case it was disabled manually.

Any Additional Information

No response

@blahdy blahdy added the bug Something isn't working label Nov 17, 2021
@khronokernel
Copy link
Member

There's a couple concerns that should be clarified due to how this issue is stated.

  1. Hibernation issues with Ivy Bridge Macs is actually quite rare compared to our user base. Blanket enabling this patch is not ideal
  • All of our internal developers have working hibernation with ConnectDrivers, however all of them are non-dGPU systems.
  1. Disabling ConnectDrivers would break support for users with multiple drives as the firmware will only connect the booted entry

Based on this, disabling ConnectDrivers should be restricted to systems with a GMUX and only have a single drive. However this cannot be dynamic due to users with either swapped ODD or external disks would no longer see their drives

This entry should be disabled by default and enabled on a per-system basis, as the user would know what situation's best for them.

@blahdy
Copy link
Author

blahdy commented Nov 17, 2021

I will try hibernation on an ivy air at some point in the near future.

What about doing a check if it is enabled and preserving that value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants