HTTP server drain

[slagiewka]

Hi!

I'm almost done adjust my GraphQL deployment to run on both Apollo and Yoga and evaluate both. One thing I still haven figured out is draining the HTTP server.

In Apollo I'm using ApolloServerPluginDrainHttpServer along stopOnTerminationSignals which registers for signals. The plugin is also wrapped with another delay function that waits couple seconds before actually starting the drain.

Is this possible with Yoga?

I see that there's onDispose but I don't think that it's reacting to SIGTERM and I'm not sure if it has anything to do with closing connections and waiting for all requests to finish.

E.g. the plugin never prints unless I run yoga.dispose() on SIGTERM manually.

      {
        onDispose: async () => {
          logger.info('disposing...');
          await setTimeout(5_000);
        },
      },

[ardatan]

Have you seen here?
https://the-guild.dev/graphql/yoga-server/docs/features/explicit-resource-management#dispose-on-nodejs

[slagiewka]

Yes! I tried enabling disposeOnProcessTerminate to get the automatic process done. But.. I think I just found a bug.

The option is never forwarded to createServerAdapter:

graphql-yoga/packages/graphql-yoga/src/server.ts

Line 659 in d1aa532

return createServerAdapter<TServerContext, YogaServer<TServerContext, TUserContext>>(server, {

[ardatan]

Until it gets fixed, you can use the other method which triggers dispose on server close.