Skip to content

Commit fb839cf

Browse files
authored
Merge branch 'dotnet:master' into roslyn-analyzers
2 parents e83ac79 + 1c3faa2 commit fb839cf

File tree

1 file changed

+23
-11
lines changed

1 file changed

+23
-11
lines changed

src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,8 @@ private static IEnumerable<Job> Expand(Job baseJob, CommandLineOptions options,
468468
}
469469
else if (!string.IsNullOrEmpty(options.ClrVersion))
470470
{
471-
yield return baseJob.WithRuntime(ClrRuntime.CreateForLocalFullNetFrameworkBuild(options.ClrVersion)); // local builds of .NET Runtime
471+
var runtime = ClrRuntime.CreateForLocalFullNetFrameworkBuild(options.ClrVersion);
472+
yield return baseJob.WithRuntime(runtime).WithId(runtime.Name); // local builds of .NET Runtime
472473
}
473474
else if (options.CliPath != null && options.Runtimes.IsEmpty() && options.CoreRunPaths.IsEmpty())
474475
{
@@ -518,9 +519,13 @@ private static Job CreateJobForGivenRuntime(Job baseJob, string runtimeId, Comma
518519
case RuntimeMoniker.Net472:
519520
case RuntimeMoniker.Net48:
520521
case RuntimeMoniker.Net481:
521-
return baseJob
522-
.WithRuntime(runtimeMoniker.GetRuntime())
523-
.WithToolchain(CsProjClassicNetToolchain.From(runtimeId, options.RestorePath?.FullName, options.CliPath?.FullName));
522+
{
523+
var runtime = runtimeMoniker.GetRuntime();
524+
return baseJob
525+
.WithRuntime(runtime)
526+
.WithId(runtime.Name)
527+
.WithToolchain(CsProjClassicNetToolchain.From(runtimeId, options.RestorePath?.FullName, options.CliPath?.FullName));
528+
}
524529

525530
case RuntimeMoniker.NetCoreApp20:
526531
case RuntimeMoniker.NetCoreApp21:
@@ -536,12 +541,19 @@ private static Job CreateJobForGivenRuntime(Job baseJob, string runtimeId, Comma
536541
case RuntimeMoniker.Net80:
537542
case RuntimeMoniker.Net90:
538543
case RuntimeMoniker.Net10_0:
539-
return baseJob
540-
.WithRuntime(runtimeMoniker.GetRuntime())
541-
.WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings(runtimeId, null, runtimeId, options.CliPath?.FullName, options.RestorePath?.FullName)));
544+
{
545+
var runtime = runtimeMoniker.GetRuntime();
546+
return baseJob
547+
.WithRuntime(runtime)
548+
.WithId(runtime.Name)
549+
.WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings(runtimeId, null, runtimeId, options.CliPath?.FullName, options.RestorePath?.FullName)));
550+
}
542551

543552
case RuntimeMoniker.Mono:
544-
return baseJob.WithRuntime(new MonoRuntime("Mono", options.MonoPath?.FullName));
553+
{
554+
var runtime = new MonoRuntime("Mono", options.MonoPath?.FullName);
555+
return baseJob.WithRuntime(runtime).WithId(runtime.Name);
556+
}
545557

546558
case RuntimeMoniker.NativeAot60:
547559
return CreateAotJob(baseJob, options, runtimeMoniker, "6.0.0-*", "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json");
@@ -636,7 +648,7 @@ private static Job CreateAotJob(Job baseJob, CommandLineOptions options, Runtime
636648
var runtime = runtimeMoniker.GetRuntime();
637649
builder.TargetFrameworkMoniker(runtime.MsBuildMoniker);
638650

639-
return baseJob.WithRuntime(runtime).WithToolchain(builder.ToToolchain());
651+
return baseJob.WithRuntime(runtime).WithToolchain(builder.ToToolchain()).WithId(runtime.Name);
640652
}
641653

642654
private static Job MakeMonoJob(Job baseJob, CommandLineOptions options, MonoRuntime runtime)
@@ -667,7 +679,7 @@ private static Job MakeMonoAOTLLVMJob(Job baseJob, CommandLineOptions options, s
667679
aotCompilerPath: options.AOTCompilerPath.ToString(),
668680
aotCompilerMode: options.AOTCompilerMode));
669681

670-
return baseJob.WithRuntime(monoAotLLVMRuntime).WithToolchain(toolChain);
682+
return baseJob.WithRuntime(monoAotLLVMRuntime).WithToolchain(toolChain).WithId(monoAotLLVMRuntime.Name);
671683
}
672684

673685
private static Job MakeWasmJob(Job baseJob, CommandLineOptions options, string msBuildMoniker, RuntimeMoniker moniker)
@@ -691,7 +703,7 @@ private static Job MakeWasmJob(Job baseJob, CommandLineOptions options, string m
691703
customRuntimePack: options.CustomRuntimePack,
692704
aotCompilerMode: options.AOTCompilerMode));
693705

694-
return baseJob.WithRuntime(wasmRuntime).WithToolchain(toolChain);
706+
return baseJob.WithRuntime(wasmRuntime).WithToolchain(toolChain).WithId(wasmRuntime.Name);
695707
}
696708

697709
private static IEnumerable<IFilter> GetFilters(CommandLineOptions options)

0 commit comments

Comments
 (0)