Skip to content

Commit 006a2d4

Browse files
committed
- Fixed Azure package pipelines to support pools in the ADO.Net and Public projects.
1 parent 67ef3d4 commit 006a2d4

File tree

2 files changed

+30
-11
lines changed

2 files changed

+30
-11
lines changed

eng/pipelines/jobs/test-azure-package-ci-job.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,9 @@ jobs:
269269
displayName: Test [${{ runtime }}]
270270
env:
271271
# Many of our tests require access to Azure resources that are
272-
# currently only granted by agents running our custom ADO-CI 1ES
273-
# images in our ADO pool.
274-
${{ if startsWith(parameters.poolName, 'ADO-CI') }}:
272+
# currently only granted by agents running our custom ADO 1ES
273+
# images in our ADO pools.
274+
${{ if startsWith(parameters.poolName, 'ADO-') }}:
275275
ADO_POOL: 1
276276
# When using connectedServiceName below, the DotNetCoreCLI task
277277
# needs the system access token to be injected as this environment

eng/pipelines/stages/build-azure-package-ci-stage.yml

Lines changed: 27 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,19 @@ parameters:
3838
- name: abstractionsPackageVersion
3939
type: string
4040

41+
# The name of the pool to use for jobs that require customized VM images.
42+
- name: adoPoolName
43+
type: string
44+
# This variable should be defined in AzureDevOps Library variable groups,
45+
# for both the Public and ADO.Net projects.
46+
#
47+
# Any pool specified here must contain images with the following names:
48+
#
49+
# - ADO-UB22-SQL22
50+
# - ADO-CI-Win11
51+
#
52+
default: $(ci_var_defaultPoolName)
53+
4154
# The name of the pipeline artifact to publish.
4255
- name: azureArtifactName
4356
type: string
@@ -47,6 +60,12 @@ parameters:
4760
- name: azurePackageVersion
4861
type: string
4962

63+
# The name of the general Azure pool to use for jobs that don't require
64+
# customized VM images.
65+
- name: azurePoolName
66+
type: string
67+
default: Azure Pipelines
68+
5069
# The type of build to produce (Release or Debug)
5170
- name: buildConfiguration
5271
type: string
@@ -126,11 +145,11 @@ stages:
126145
mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
127146
netFrameworkRuntimes: []
128147
netRuntimes: [net8.0, net9.0]
129-
poolName: Azure Pipelines
148+
poolName: ${{ parameters.azurePoolName }}
130149
referenceType: ${{ parameters.referenceType }}
131150
vmImage: ubuntu-latest
132151

133-
# Use our 1ES ADO-CI pool for comprehensive testing.
152+
# Use our 1ES ADO pool for comprehensive testing.
134153
- template: ../jobs/test-azure-package-ci-job.yml@self
135154
parameters:
136155
abstractionsArtifactName: ${{ parameters.abstractionsArtifactName }}
@@ -144,7 +163,7 @@ stages:
144163
mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
145164
netFrameworkRuntimes: []
146165
netRuntimes: [net8.0, net9.0]
147-
poolName: ADO-CI-1ES-Pool
166+
poolName: ${{ parameters.adoPoolName }}
148167
referenceType: ${{ parameters.referenceType }}
149168
vmImage: ADO-UB22-SQL22
150169

@@ -165,11 +184,11 @@ stages:
165184
mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
166185
netFrameworkRuntimes: [net462]
167186
netRuntimes: [net8.0, net9.0]
168-
poolName: Azure Pipelines
187+
poolName: ${{ parameters.azurePoolName }}
169188
referenceType: ${{ parameters.referenceType }}
170189
vmImage: windows-latest
171190

172-
# Use our 1ES ADO-CI pool for comprehensive testing.
191+
# Use our 1ES ADO pool for comprehensive testing.
173192
- template: ../jobs/test-azure-package-ci-job.yml@self
174193
parameters:
175194
abstractionsArtifactName: ${{ parameters.abstractionsArtifactName }}
@@ -183,7 +202,7 @@ stages:
183202
mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
184203
netFrameworkRuntimes: [net462]
185204
netRuntimes: [net8.0, net9.0]
186-
poolName: ADO-CI-1ES-Pool
205+
poolName: ${{ parameters.adoPoolName }}
187206
referenceType: ${{ parameters.referenceType }}
188207
vmImage: ADO-CI-Win11
189208

@@ -204,11 +223,11 @@ stages:
204223
mdsPackageVersion: ${{ parameters.mdsPackageVersion }}
205224
netFrameworkRuntimes: []
206225
netRuntimes: [net8.0, net9.0]
207-
poolName: Azure Pipelines
226+
poolName: ${{ parameters.azurePoolName }}
208227
referenceType: ${{ parameters.referenceType }}
209228
vmImage: macos-latest
210229

211-
# We do not currently have any images in our 1ES ADO-CI pool for macOS.
230+
# We do not currently have any images in our 1ES ADO pools for macOS.
212231

213232
# ------------------------------------------------------------------------
214233
# Create and publish the NuGet package.

0 commit comments

Comments
 (0)