-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Labels
Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver.Issues/PRs that are related with breaking API changes in the driver.Enhancement 💡Issues that are feature requests for the drivers we maintain.Issues that are feature requests for the drivers we maintain.
Description
Below are proposals to revamp SQL Authentication Provider APIs, captured from PR #3680 by @paulmedynski
Provider registration APIs:
- Make
GetProvider()andSetProvider()public onSqlAuthenticationProviderManager. These are the actual implementation of provider management. - Deprecate
GetProvider()andSetProvider()onSqlAuthenticationProvider. These are management functions that don't belong on the base abstract class used to implement providers. - Point to the
SqlAuthenticationProviderManagermethods as the replacement. Removing these methods will eliminate fragile runtime reflection from the MDS.Abstractions package.
Authentication Timeout APIs:
- Add an
AuthenticationTimeoutproperty toSqlAuthenticationParameter. This is a more accurate name than the existingConnectionTimeoutproperty. - Deprecate
SqlAuthenticationParameter'sConnectionTimeoutproperty. Implement it in terms ofAuthenticationTimeout. - Direct callers to
AuthenticationTimeoutproperty. - Rename
SqlAuthenticationParameter'sConnectionTimeoutconstructor argument. We can't actually do this since C# doesn't provide a mechanism to maintain backwards compatibility with callers that are supplying the timeout value by name 🙁 - Document the intention of the connectionTimeout argument as clearly as possible.
Designers: @saurabh500 and @paulmedynski
edwardneal
Metadata
Metadata
Assignees
Labels
Breaking Change 🔨Issues/PRs that are related with breaking API changes in the driver.Issues/PRs that are related with breaking API changes in the driver.Enhancement 💡Issues that are feature requests for the drivers we maintain.Issues that are feature requests for the drivers we maintain.