Document Apache cookie spec factory - #556
Conversation
Refs #266 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR replaces “To be added.” placeholders in the XML documentation for Org.Apache.Http.Cookies.ICookieSpecFactory, aligning the docs more closely with the upstream Apache HttpClient CookieSpecFactory API and improving IntelliSense quality for this namespace.
Changes:
- Added a concrete type-level
<summary>forICookieSpecFactory. - Documented the
NewInstance(IHttpParams params)method’s parameter, summary, and return value.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #266 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
The new ICookieSpecFactory summaries and parameter/return text closely derive from Apache HttpClient Javadoc, but the page attributes them only to AOSP under CC BY 2.5. Please add the appropriate Apache HttpClient/Apache-2.0 attribution and required notices, or replace the text with independently authored documentation approved under repository policy.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b143e1ee-57ea-434e-a1a5-ce76b1da1037
|
Addressed in 2556ec8 by replacing the Apache-derived wording with independently authored documentation while retaining the existing API references and repository attribution. |
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
The cookie specification factory now uses independently authored, accurate documentation with valid signatures, references, and attribution.
Refs #266
Sources
Validation