Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewPager2 with tab navigation #87

Closed
knuxbbs opened this issue Apr 7, 2020 · 12 comments
Closed

ViewPager2 with tab navigation #87

knuxbbs opened this issue Apr 7, 2020 · 12 comments
Assignees
Labels
in-progress in progress update-package-request Request for a NuGet to be updated to newer Java package version

Comments

@knuxbbs
Copy link

knuxbbs commented Apr 7, 2020

Xamarin.Android Version (eg: 6.0):

10.2.99.180

Operating System & Version (eg: Mac OSX 10.11):

Ubuntu 19.10

Support Libraries Version (eg: 23.3.0):

Xamarin.Google.Android.Material 1.0.0

Describe your Issue:

I'm trying to implement a ViewPager2 with tab navigation, based on this guide, but I noticed that there isn't a TabLayoutMediator binding in the Xamarin.Google.Android.Material package. There is a workaround to do this with ViewPager2, or do I will have to wait to the next releases?

@moljac moljac self-assigned this Apr 8, 2020
@moljac
Copy link
Contributor

moljac commented Apr 8, 2020

but I noticed that there isn't a TabLayoutMediator binding in the Xamarin.Google.Android.Material package.

if I recall it correctly it is not in 1.0.0, but in version 1.1.0.

OK I don't have whole API or changelogs in my head, so I might be wrong.

There is a workaround to do this with ViewPager2, or do I will have to wait to the next releases?

There is version 1.1.0-rc3 of Material, but there is a bug and fix/workaround which needs more testing. Until 1.1.0 is released as stable you will have to stick with rc or not use this feature.

https://www.nuget.org/packages/Xamarin.Google.Android.Material/1.1.0-rc3

@Shikada
Copy link

Shikada commented Apr 21, 2020

Hi, can you link the bug/workaround that is blocking this? Is this the only blocker for a stable 1.1.0 release? Is there any way I could try to contribute to this?

@b2yq
Copy link

b2yq commented May 6, 2020

i was trying to use rc3, but constructor of a TabLayoutMediator requiring 3rd parameter: ITabConfigurationStrategy and this interface looks like a C#<=>Java wrapper, so do you have any example how to implement this one?

@moljac
Copy link
Contributor

moljac commented May 6, 2020

@oocpawel @Shikada @knuxbbs

Well, google has done quite a lot of changes between 1.0.0 and 1.1.0 and add to that java generics which are problem to bind and "translate" to .NET world - this leads to big issue.
We have came up with workaround which is being tested.

Guys (and gals) I am working on that, but priorities might not be what you would like, but, now that GPS-FB with AndroidX dependencies are published, I'm getting closer to the point in time when I will be able to finish this.

@moljac moljac added the in-progress in progress label Jul 13, 2020
@jpobst jpobst added update-package-request Request for a NuGet to be updated to newer Java package version and removed packages labels Nov 5, 2020
@jpobst
Copy link
Contributor

jpobst commented Nov 11, 2020

There is now a stable package of Xamarin.Google.Android.Material 1.1.0 available:
https://www.nuget.org/packages/Xamarin.Google.Android.Material/1.1.0.5

@jpobst jpobst closed this as completed Nov 11, 2020
@b2yq
Copy link

b2yq commented Nov 24, 2020

Why its closed if 1.1.0.5 still requires ITabConfigurationStrategy which wasn't implemented in Xamarin.Android? This bug title is saying "ViewPager2 with tab navigation" and right now in 1.1.0.5 it can't be done without ITabConfigurationStrategy implementation.

@jpobst
Copy link
Contributor

jpobst commented Nov 24, 2020

I'm not sure what you mean by "not implemented"? It seems to exist in 1.1.0.5:

image

I can re-open the issue if it still isn't working.

@carlos-lobo-bessa
Copy link

carlos-lobo-bessa commented Nov 24, 2020

@jpobst

I'm currently having an issue with ITabConfigurationStrategy

Screenshot 2020-11-24 at 17 34 24

Is this a known issue? I only get this error the moment I build the project

@jpobst
Copy link
Contributor

jpobst commented Nov 24, 2020

I do not get an error when I build and run the code I posted, so it must be something specific to your project or the way you are using it. Can you provide a repro case so I can investigate?

@jpobst jpobst reopened this Nov 24, 2020
@carlos-lobo-bessa
Copy link

@jpobst Let me try to replicate this on a separate project.

@carlos-lobo-bessa
Copy link

@jpobst I'm unable to replicate this issue in a new project, when I create a new project im able to use ITabConfigurationStrategy just fine, it must be something specific to my project.

@jpobst
Copy link
Contributor

jpobst commented May 24, 2022

Our team is unable to investigate this issue further without the requested information.

Hopefully you found a resolution! If not, please update to the latest version of the product and if the problem still occurs, reply with the requested information and reopen this issue.

@jpobst jpobst closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress in progress update-package-request Request for a NuGet to be updated to newer Java package version
Projects
None yet
Development

No branches or pull requests

6 participants