Skip to content

Commit 98730a8

Browse files
committed
Address review feedback.
1 parent 90b42d8 commit 98730a8

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

src/Xamarin.Android.Build.Tasks/Linker/MonoDroid.Tuner/FindJavaObjectsStep.cs

+4-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,10 @@ List<CallableWrapperType> ConvertToCallableWrappers (List<TypeDefinition> types)
8585
if (UseMarshalMethods)
8686
reader_options.MethodClassifier = new MarshalMethodsClassifier (Context, Context.Resolver, Log);
8787

88-
foreach (var type in types)
89-
wrappers.Add (CecilImporter.CreateType (type, Context, reader_options));
88+
foreach (var type in types) {
89+
var wrapper = CecilImporter.CreateType (type, Context, reader_options);
90+
wrappers.Add (wrapper);
91+
}
9092

9193
return wrappers;
9294
}

src/Xamarin.Android.Build.Tasks/Tasks/GenerateACWMap.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void GenerateMap ()
7474
return;
7575
}
7676

77-
var xml = JavaObjectsXmlFile.Import (wrappersPath, JavaObjectsXmlFileReadType.ACW);
77+
var xml = JavaObjectsXmlFile.Import (wrappersPath, JavaObjectsXmlFileReadType.AndroidResourceFixups);
7878

7979
entries.AddRange (xml.ACWMapEntries);
8080
}

src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaCallableWrappers.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void GenerateWrappers (List<ITaskItem> assemblies)
6969
return;
7070
}
7171

72-
var xml = JavaObjectsXmlFile.Import (wrappersPath, JavaObjectsXmlFileReadType.JCW);
72+
var xml = JavaObjectsXmlFile.Import (wrappersPath, JavaObjectsXmlFileReadType.JavaCallableWrappers);
7373

7474
if (xml.JavaCallableWrappers.Count == 0) {
7575
Log.LogDebugMessage ($"'{wrappersPath}' is empty, skipping.");

src/Xamarin.Android.Build.Tasks/Utilities/JavaObjectsXmlFile.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,10 @@ public static JavaObjectsXmlFile Import (string filename, JavaObjectsXmlFileRead
107107
var xml = XDocument.Load (filename);
108108

109109
// We let callers specify which part(s) of the file they want to deserialize to save time
110-
if (readType.HasFlag (JavaObjectsXmlFileReadType.JCW) && xml.Root?.Element ("jcw-types") is XElement jcw)
110+
if (readType.HasFlag (JavaObjectsXmlFileReadType.JavaCallableWrappers) && xml.Root?.Element ("jcw-types") is XElement jcw)
111111
file.JavaCallableWrappers.AddRange (XmlImporter.Import (jcw));
112112

113-
if (readType.HasFlag (JavaObjectsXmlFileReadType.ACW) && xml.Root?.Element ("acw-types") is XElement acw) {
113+
if (readType.HasFlag (JavaObjectsXmlFileReadType.AndroidResourceFixups) && xml.Root?.Element ("acw-types") is XElement acw) {
114114
var partialAssemblyName = acw.GetAttributeOrDefault ("partial-assembly-name", string.Empty);
115115
var moduleName = acw.GetAttributeOrDefault ("module-name", string.Empty);
116116

@@ -136,6 +136,6 @@ public static void WriteEmptyFile (string destination, TaskLoggingHelper log)
136136
enum JavaObjectsXmlFileReadType
137137
{
138138
None = 0,
139-
ACW = 1,
140-
JCW = 2,
139+
AndroidResourceFixups = 1,
140+
JavaCallableWrappers = 2,
141141
}

0 commit comments

Comments
 (0)