Skip to content

Commit 9ddebbc

Browse files
committed
Let's see how this works
1 parent b11d0ac commit 9ddebbc

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

build-tools/automation/yaml-templates/run-msbuild-tests.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
parameters:
22
testOS: '' # 'macOS' or 'Windows'
3+
runtimeName: '' # MonoVM or CoreCLR
34
jobName: '' # Name of the job
45
jobDisplayName: '' # Display name of the job
56
agentCount: 1 # Number of build agents to run in parallel
@@ -48,20 +49,20 @@ jobs:
4849

4950
- task: DownloadPipelineArtifact@2
5051
inputs:
51-
artifactName: $(TestAssembliesArtifactName)
52+
artifactName: $(TestAssembliesArtifactName)-${{ parameters.runtimeName }}
5253
downloadPath: ${{ parameters.xaSourcePath }}/bin/Test$(XA.Build.Configuration)
5354

5455
- template: /build-tools/automation/yaml-templates/run-sliced-nunit-tests.yaml
5556
parameters:
5657
testAssembly: ${{ parameters.xaSourcePath }}/bin/Test$(XA.Build.Configuration)/$(DotNetStableTargetFramework)/Xamarin.Android.Build.Tests.dll
5758
testFilter: ${{ parameters.testFilter }}
58-
testRunTitle: Xamarin.Android.Build.Tests - ${{ parameters.testOS }}
59+
testRunTitle: Xamarin.Android.Build.Tests - ${{ parameters.testOS }} (${{ parameters.runtimeName }})
5960
retryFailedTests: false
6061
xaSourcePath: ${{ parameters.xaSourcePath }}
6162

6263
- template: /build-tools/automation/yaml-templates/upload-results.yaml
6364
parameters:
64-
artifactName: Test Results - MSBuild - ${{ parameters.testOS }}-$(System.JobPositionInPhase)
65+
artifactName: Test Results - MSBuild - ${{ parameters.testOS }}-${{ parameters.runtimeName }}-$(System.JobPositionInPhase)
6566
xaSourcePath: ${{ parameters.xaSourcePath }}
6667
use1ESTemplate: ${{ parameters.use1ESTemplate }}
6768

build-tools/automation/yaml-templates/stage-linux-tests.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ stages:
1111
jobs:
1212
# Check - "Xamarin.Android (Linux Tests Linux > Tests > MSBuild)"
1313
- job: linux_tests_smoke_1
14-
displayName: Linux > Tests > MSBuild 1
14+
displayName: Linux > Tests > MSBuild 1 (${{ parameters.runtimeName }})
1515
pool:
1616
name: MAUI-1ESPT
1717
image: $(LinuxPoolImage1ESPT)
@@ -28,19 +28,19 @@ stages:
2828

2929
- task: DownloadPipelineArtifact@2
3030
inputs:
31-
artifactName: $(TestAssembliesArtifactName)
31+
artifactName: $(TestAssembliesArtifactName)-${{ parameters.rutimeName }}
3232
downloadPath: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)
3333

3434
- template: /build-tools/automation/yaml-templates/run-nunit-tests.yaml
3535
parameters:
36-
testRunTitle: Xamarin.Android.Build.Tests - Linux BuildTest
36+
testRunTitle: Xamarin.Android.Build.Tests - Linux BuildTest (${{ parameters.runtimeName }})
3737
testAssembly: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)/$(DotNetStableTargetFramework)/Xamarin.Android.Build.Tests.dll
3838
dotNetTestExtraArgs: --filter "Name = BuildTest"
3939

4040
- template: /build-tools/automation/yaml-templates/upload-results.yaml
4141
parameters:
4242
configuration: $(XA.Build.Configuration)
43-
artifactName: Test Results - MSBuild - Linux 1
43+
artifactName: Test Results - MSBuild - Linux 1 - ${{ parameters.runtimeName }}
4444

4545
- template: /build-tools/automation/yaml-templates/fail-on-issue.yaml
4646

@@ -62,24 +62,24 @@ stages:
6262

6363
- task: DownloadPipelineArtifact@2
6464
inputs:
65-
artifactName: $(TestAssembliesArtifactName)
65+
artifactName: $(TestAssembliesArtifactName)-${{ parameters.runtimeName }}
6666
downloadPath: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)
6767

6868
- template: /build-tools/automation/yaml-templates/run-nunit-tests.yaml
6969
parameters:
70-
testRunTitle: Xamarin.Android.Build.Tests - Linux PackagingTest
70+
testRunTitle: Xamarin.Android.Build.Tests - Linux PackagingTest (${{ parameters.runtimeName }})
7171
testAssembly: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)/$(DotNetStableTargetFramework)/Xamarin.Android.Build.Tests.dll
7272
dotNetTestExtraArgs: --filter "Name = PackagingTest"
7373

7474
- template: /build-tools/automation/yaml-templates/run-nunit-tests.yaml
7575
parameters:
76-
testRunTitle: Xamarin.Android.Build.Tests - Linux XASdkTests
76+
testRunTitle: Xamarin.Android.Build.Tests - Linux XASdkTests (${{ parameters.runtimeName }})
7777
testAssembly: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)/$(DotNetStableTargetFramework)/Xamarin.Android.Build.Tests.dll
7878
dotNetTestExtraArgs: --filter "Name = XASdkTests & Name != XamarinLegacySdk"
7979

8080
- template: /build-tools/automation/yaml-templates/run-nunit-tests.yaml
8181
parameters:
82-
testRunTitle: Xamarin.Android.Build.Tests - Linux AndroidDependenciesTests
82+
testRunTitle: Xamarin.Android.Build.Tests - Linux AndroidDependenciesTests (${{ parameters.runtimeName }})
8383
testAssembly: $(System.DefaultWorkingDirectory)/bin/Test$(XA.Build.Configuration)/$(DotNetStableTargetFramework)/Xamarin.Android.Build.Tests.dll
8484
dotNetTestExtraArgs: --filter "Name = AndroidDependenciesTests"
8585

@@ -92,6 +92,6 @@ stages:
9292
- template: /build-tools/automation/yaml-templates/upload-results.yaml
9393
parameters:
9494
configuration: $(XA.Build.Configuration)
95-
artifactName: Test Results - MSBuild - Linux 2
95+
artifactName: Test Results - MSBuild - Linux 2 - ${{ parameters.runtimeName }}
9696

9797
- template: /build-tools/automation/yaml-templates/fail-on-issue.yaml

build-tools/automation/yaml-templates/stage-msbuild-tests.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ stages:
2121
- template: /build-tools/automation/yaml-templates/run-msbuild-tests.yaml
2222
parameters:
2323
testOS: macOS
24+
runtimeName: ${{ parameters.runtimeName }}
2425
jobName: mac_msbuild_tests
2526
jobDisplayName: macOS > Tests > MSBuild
2627
agentCount: 10
@@ -33,6 +34,7 @@ stages:
3334
- template: /build-tools/automation/yaml-templates/run-msbuild-tests.yaml
3435
parameters:
3536
testOS: Windows
37+
runtimeName: ${{ parameters.runtimeName }}
3638
jobName: win_msbuild_tests
3739
jobDisplayName: Windows > Tests > MSBuild
3840
agentCount: 8

src/Xamarin.Android.Build.Tasks/Tasks/GenerateTypeMappings.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,6 @@ void WriteTypeMappings (NativeCodeGenState state)
7777
// NativeAOT typemaps are generated in `Microsoft.Android.Sdk.ILLink.TypeMappingStep`
7878
return;
7979
}
80-
if (androidRuntime == Xamarin.Android.Tasks.AndroidRuntime.CoreCLR) {
81-
// TODO: CoreCLR typemaps will be emitted later
82-
return;
83-
}
8480
Log.LogDebugMessage ($"Generating type maps for architecture '{state.TargetArch}'");
8581
var tmg = new TypeMapGenerator (Log, state, androidRuntime);
8682
if (!tmg.Generate (Debug, SkipJniAddNativeMethodRegistrationAttributeScan, TypemapOutputDirectory, GenerateNativeAssembly)) {

0 commit comments

Comments
 (0)