Skip to content

Commit aea3b79

Browse files
committed
Switch more tests to 64-bit ABIs
1 parent e78e9cd commit aea3b79

File tree

1 file changed

+10
-2
lines changed
  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests

1 file changed

+10
-2
lines changed

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs

+10-2
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,10 @@ public void DotNetBuild (string runtimeIdentifiers, bool isRelease, bool aot, bo
229229
[TestCaseSource (nameof (MonoComponentMaskChecks))]
230230
public void CheckMonoComponentsMask (bool enableProfiler, bool useInterpreter, bool debugBuild, uint expectedMask)
231231
{
232+
if (TargetRuntimeHelper.UseCoreCLR) {
233+
Assert.Ignore ("CoreCLR does not support MonoVM components");
234+
}
235+
232236
var proj = new XamarinFormsAndroidApplicationProject () {
233237
IsRelease = !debugBuild,
234238
};
@@ -271,13 +275,17 @@ public void CheckMonoComponentsMask (bool enableProfiler, bool useInterpreter, b
271275
[NonParallelizable]
272276
public void CheckAssemblyCounts (bool isRelease, bool aot)
273277
{
278+
if (aot && TargetRuntimeHelper.UseCoreCLR) {
279+
Assert.Ignore ("CoreCLR doesn't support MonoVM-style AOT");
280+
}
281+
274282
var proj = new XamarinFormsAndroidApplicationProject {
275283
IsRelease = isRelease,
276284
EmbedAssembliesIntoApk = true,
277285
AotAssemblies = aot,
278286
};
279287

280-
var abis = new [] { "armeabi-v7a", "x86" };
288+
var abis = new [] { "arm64-v8a", "x86_64" };
281289
proj.SetRuntimeIdentifiers (abis);
282290
proj.SetProperty (proj.ActiveConfigurationProperties, "AndroidUseAssemblyStore", "True");
283291

@@ -1273,7 +1281,7 @@ public void PackageNamingPolicy ([Values ("LowercaseMD5", "LowercaseCrc64")] str
12731281
var proj = new XamarinAndroidApplicationProject ();
12741282
proj.SetProperty ("UseInterpreter", "true");
12751283
proj.SetProperty ("AndroidPackageNamingPolicy", packageNamingPolicy);
1276-
proj.SetAndroidSupportedAbis ("armeabi-v7a", "x86");
1284+
proj.SetAndroidSupportedAbis ("arm64-v8a", "x86_64");
12771285
using (var b = CreateApkBuilder ()) {
12781286
Assert.IsTrue (b.Build (proj), "build should have succeeded.");
12791287
var environment = b.Output.GetIntermediaryPath (Path.Combine ("__environment__.txt"));

0 commit comments

Comments
 (0)