Enable more tests to run on all 3 runtimes, part 12 (#10632)

This pull request extends runtime testing capabilities by enabling more tests to run across
all three Android runtimes (MonoVM, CoreCLR, and NativeAOT). The changes are part 12
of a larger effort to ensure comprehensive runtime test coverage.

**Key Changes:**
- Refactored test parameters to use `[Values] AndroidRuntime` instead of hardcoded
  runtime values, enabling tests to run with all available runtimes
- Converted static test case arrays to dynamic test case generators that iterate through
  runtime enumerations
- Added NativeAOT-specific handling for file paths and test assertions, with appropriate
  ignore conditions for currently unsupported scenarios

Author: grendello

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/EnvironmentHelper.cs

@@ -765,12 +765,15 @@ static void AssertApplicationConfigIsIdentical (ApplicationConfig_MonoVM firstAp
 			Assert.AreEqual (firstAppConfig.android_package_name, secondAppConfig.android_package_name, $"Field 'android_package_name' has different value in environment file '{secondEnvFile}' than in environment file '{firstEnvFile}'");
 		}
 
-		public static List<EnvironmentFile> GatherEnvironmentFiles (string outputDirectoryRoot, string supportedAbis, bool required)
+		// TODO: remove the default from the `runtime` parameter once all tests are updated
+		public static List<EnvironmentFile> GatherEnvironmentFiles (string outputDirectoryRoot, string supportedAbis, bool required, AndroidRuntime runtime = AndroidRuntime.CoreCLR)
 		{
 			var environmentFiles = new List <EnvironmentFile> ();
+			bool isNativeAOT = runtime == AndroidRuntime.NativeAOT;
 
 			foreach (string abi in supportedAbis.Split (';')) {
-				string envFilePath = Path.Combine (outputDirectoryRoot, "android", $"environment.{abi}.ll");
+				string prefixDir = isNativeAOT ? MonoAndroidHelper.AbiToRid (abi) : String.Empty;
+				string envFilePath = Path.Combine (outputDirectoryRoot, prefixDir, "android", $"environment.{abi}.ll");
 
 				Assert.IsTrue (File.Exists (envFilePath), $"Environment file {envFilePath} does not exist");
 				environmentFiles.Add (new EnvironmentFile (envFilePath, abi));

tests/MSBuildDeviceIntegration/Tests/BundleToolNoAbiSplitTests.cs

@@ -9,8 +9,7 @@
 
 namespace Xamarin.Android.Build.Tests
 {
-	[TestFixture (AndroidRuntime.MonoVM)]
-	[TestFixture (AndroidRuntime.CoreCLR)]
+	[TestFixtureSource (nameof (Get_ConstructorParameters))]
 	[Category ("UsesDevice")]
 	public class BundleToolNoAbiSplitTests : DeviceTest
 	{
@@ -37,6 +36,11 @@ public class BundleToolNoAbiSplitTests : DeviceTest
 }";
 		readonly AndroidRuntime runtime;
 
+		static Array Get_ConstructorParameters ()
+		{
+			return Enum.GetValues (typeof (AndroidRuntime));
+		}
+
 		public BundleToolNoAbiSplitTests (AndroidRuntime runtime)
 		{
 			this.runtime = runtime;
@@ -127,19 +131,22 @@ public void OneTimeSetUp ()
                         List<EnvironmentHelper.EnvironmentFile> envFiles = EnvironmentHelper.GatherEnvironmentFiles (
                                 objPath,
                                 String.Join (";", Abis),
-                                true
+                                true,
+				runtime
                         );
 
-                        EnvironmentHelper.IApplicationConfig app_config = EnvironmentHelper.ReadApplicationConfig (envFiles, runtime);
+			if (runtime != AndroidRuntime.NativeAOT) { // NAOT doesn't have ApplicationConfig
+				EnvironmentHelper.IApplicationConfig app_config = EnvironmentHelper.ReadApplicationConfig (envFiles, runtime);
 
-			Assert.That (app_config, Is.Not.Null, "application_config must be present in the environment files");
+				Assert.That (app_config, Is.Not.Null, "application_config must be present in the environment files");
 
-			bool ignoreSplitConfigs = runtime switch {
-				AndroidRuntime.MonoVM  => ((EnvironmentHelper.ApplicationConfig_MonoVM)app_config).ignore_split_configs,
-				AndroidRuntime.CoreCLR => ((EnvironmentHelper.ApplicationConfig_CoreCLR)app_config).ignore_split_configs,
-				_                      => throw new NotSupportedException ($"Unsupported runtime '{runtime}'")
-			};
-                        Assert.AreEqual (ignoreSplitConfigs, true, $"App config should indicate that split configs must be ignored");
+				bool ignoreSplitConfigs = runtime switch {
+					AndroidRuntime.MonoVM  => ((EnvironmentHelper.ApplicationConfig_MonoVM)app_config).ignore_split_configs,
+					AndroidRuntime.CoreCLR => ((EnvironmentHelper.ApplicationConfig_CoreCLR)app_config).ignore_split_configs,
+					_                      => throw new NotSupportedException ($"Unsupported runtime '{runtime}'")
+				};
+				Assert.AreEqual (ignoreSplitConfigs, true, $"App config should indicate that split configs must be ignored");
+			}
 		}
 
 		[TearDown]
@@ -161,6 +168,18 @@ public void OneTimeTearDown ()
 		[Test]
 		public void InstallAndRun ()
 		{
+			// TODO: fix under NativeAOT. Currently fails with an exception at run time:
+			//
+			// FATAL UNHANDLED EXCEPTION: System.InvalidCastException: Unable to convert instance of type 'AndroidX.AppCompat.Widget.AppCompatImageButton' to type 'AndroidX.AppCompat.Widget.Toolbar'.
+			//    at Java.Interop.JavaObjectExtensions._JavaCast[TResult](IJavaObject) + 0x165
+			//    at Android.Runtime.Extensions.JavaCast[TResult](IJavaObject) + 0x10
+			//    at Xamarin.Forms.Platform.Android.FormsAppCompatActivity.OnCreate(Bundle, ActivationFlags) + 0x601
+			//    at UnnamedProject.MainActivity.OnCreate(Bundle savedInstanceState) + 0x3c
+			//    at Android.App.Activity.n_OnCreate_Landroid_os_Bundle_(IntPtr jnienv, IntPtr native__this, IntPtr native_savedInstanceState) + 0x72
+			//
+			if (runtime == AndroidRuntime.NativeAOT) {
+				Assert.Ignore ("NativeAOT crashes with an InvalidCastException exception");
+			}
 			Assert.IsTrue (appBuilder.Install (app), "Install should have succeeded.");
 			RunProjectAndAssert (app, appBuilder);
 			Assert.True (

tests/MSBuildDeviceIntegration/Tests/BundleToolTests.cs

@@ -48,11 +48,10 @@ static IEnumerable<object[]> Get_FixtureArgs ()
 				new object[] { false },
 				new object[] { true },
 			};
-			var runtimes = new [] { AndroidRuntime.MonoVM, AndroidRuntime.CoreCLR };
 			var ret = new List<object[]> ();
 
 			foreach (object[] args in fixtureArgs) {
-				foreach (AndroidRuntime runtime in runtimes) {
+				foreach (AndroidRuntime runtime in Enum.GetValues (typeof (AndroidRuntime))) {
 					ret.Add (new object[] {
 						args[0],
 						runtime,
@@ -72,10 +71,15 @@ public BundleToolTests (bool usesAssemblyBlobs, AndroidRuntime runtime)
 		[OneTimeSetUp]
 		public void OneTimeSetUp ()
 		{
+			const bool isRelease = true;
+			if (IgnoreUnsupportedConfiguration (runtime, release: isRelease)) {
+				return;
+			}
+
 			var path = Path.Combine ("temp", TestName);
 			lib = new XamarinAndroidLibraryProject {
 				ProjectName = "Localization",
-				IsRelease = true,
+				IsRelease = isRelease,
 				OtherBuildItems = {
 					new BuildItem ("EmbeddedResource", "Foo.resx") {
 						TextContent = () => InlineData.ResxWithContents ("<data name=\"CancelButton\"><value>Cancel</value></data>")
@@ -91,7 +95,7 @@ public void OneTimeSetUp ()
 
 			var bytes = new byte [1024];
 			app = new XamarinFormsMapsApplicationProject {
-				IsRelease = true,
+				IsRelease = isRelease,
 				AotAssemblies = false, // Release defaults to Profiled AOT for .NET 6
 				PackageName = "com.xamarin.bundletooltests",
 			};
@@ -186,6 +190,11 @@ public void BaseZip ()
 			expectedFiles.Add ("root/play-services-tasks.properties");
 
 			foreach (var abi in Abis) {
+				if (runtime == AndroidRuntime.NativeAOT) {
+					expectedFiles.Add ($"lib/{abi}/libUnnamedProject.so");
+					continue;
+				}
+
 				// All assemblies are in per-abi directories now
 				if (usesAssemblyBlobs) {
 					expectedFiles.Add ($"{blobEntryPrefix}{abi}/lib_Java.Interop.dll.so");
@@ -250,6 +259,11 @@ public void AppBundle ()
 			expectedFiles.Add ("base/root/play-services-tasks.properties");
 
 			foreach (var abi in Abis) {
+				if (runtime == AndroidRuntime.NativeAOT) {
+					expectedFiles.Add ($"base/lib/{abi}/libUnnamedProject.so");
+					continue;
+				}
+
 				// All assemblies are in per-abi directories now
 				if (usesAssemblyBlobs) {
 					expectedFiles.Add ($"{blobEntryPrefix}{abi}/lib_Java.Interop.dll.so");