Update System.IO.Compression to use the best compression. #9838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`System.IO.Compression`` uses the default compression level which is not the best compression level. This change updates the compression level to the best compression level since the size of the Apk is very important. Unfortunately, the best compression enum level is not available on `netstandard2.0`. So we have to use a cast to get it to work.
|
Should we make an MSBuild property to toggle the enum? Then we could consider debug mode using a "fast" compression and Release doing a "slow" but small compression? |
|
We should probably have performance data on this to understand the tradeoffs. For a Debug build compression time is probably more important than compression size. Also, the Release Archive size differences between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
`System.IO.Compression`` uses the default compression level which is not the Smallest compression level. This change updates the compression level to the best compression level since the size of the Apk is very important.
Unfortunately, the SmallestSize compression enum level is not available on
netstandard2.0. So we have to use a cast to get it to work.