Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run SignCheck on .NET Core #15470

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jan 30, 2025

Fixes dotnet/source-build#4848

This PR includes the following changes to allow SignCheck to run on .NET Core:

  • Breaks SignCheck into two projects, a cli project and a task project. This is necessary to be able to keep repos that currently use the framework executable from being disrupted by the addition of .NET Core as a target framework. The cli executable is only available to run on framework, whereas the task can run on both core and framework.
  • Disables authenticode verification on .NET Core. This functionality is currently unusable on .NET Core
  • Adds eng/common/sdk-task.sh to run the sdk task on mac & linux.

@ellahathaway
Copy link
Member Author

ellahathaway commented Jan 30, 2025

Testing in pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=2631754&view=results

Updated pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634190&view=results

Errors are expected! I intentionally tested the validation on mac & linux with signed and non-signed artifacts. The SignCheck correctly marked the signed and unsigned packages.

Having issues with the file path permissions on linux and mac in the test pipeline run & need to figure out why the tests failed in this PR, but the general content of this PR is otherwise ready to be reviewed.

Fixed with b325256

Going to mark this PR as ready to review to get a review on the current state, but adding the do not merge label.

Removing the label.

@ellahathaway ellahathaway requested a review from mmitche January 30, 2025 23:06
@ellahathaway ellahathaway marked this pull request as ready for review January 30, 2025 23:07
mmitche
mmitche previously approved these changes Jan 31, 2025
@ellahathaway ellahathaway merged commit fbc0780 into dotnet:main Feb 5, 2025
11 checks passed
@ellahathaway ellahathaway deleted the signcheck-netcore branch February 5, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable SignCheck on .NET Core
2 participants