Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag #12960

Copilot · 2025-11-14T00:53:10Z

Description

Default pipeline steps in DistributedApplicationPipeline were not tagged, preventing them from being queried by tag in pipeline configuration callbacks. This made it difficult to create dependencies on groups of default steps (e.g., "run after all build steps complete").

Changes:

Tagged DeployPrereq with ProvisionInfrastructure (performs infrastructure provisioning)
Tagged Build and BuildPrereq with BuildCompute (perform build operations)
Left Deploy, Publish, and PublishPrereq untagged (meta/coordination steps that don't perform actions themselves)
Left Diagnostics step untagged (debugging/troubleshooting step, not part of deployment workflow)
Added test to verify tag assignments
Renamed GetSteps(string tag) to GetStepsByTag(string tag) for clarity when multiple overloads exist

Rationale:
Tags are only applied to steps that actually perform the tagged actions. Meta/coordination steps (Deploy, Publish, PublishPrereq) don't have tags because they don't perform these actions themselves - they just coordinate when other steps run. This aligns with how tags are used throughout the codebase.

Usage:

pipeline.AddPipelineConfiguration((context) =>
{
    // Can now query default steps by tag
    var buildSteps = context.GetStepsByTag(WellKnownPipelineTags.BuildCompute);
    var provisionSteps = context.GetStepsByTag(WellKnownPipelineTags.ProvisionInfrastructure);
    
    // Create dependencies on groups of action-performing steps
    myStep.DependsOn(buildSteps);
});

Aligns default steps with tagging pattern already used by resource-specific steps (e.g., ProjectResource, AzureBicepResource).

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire-docs issue (consider using one of the following templates):
- No

Original prompt

Add tags to all the steps that are registered by default in the DistributedApplicationPipeline and have a WellKnownPipelineTag.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Add appropriate WellKnownPipelineTag tags to all default steps registered in DistributedApplicationPipeline: - Deploy step: DeployCompute tag - DeployPrereq step: ProvisionInfrastructure tag - Build step: BuildCompute tag - BuildPrereq step: BuildCompute tag - Publish step: PushContainerImage tag - PublishPrereq step: PushContainerImage tag - Diagnostics step: No tag (diagnostic step) Also added test to verify tags are correctly assigned to default steps. Co-authored-by: captainsafia <[email protected]>

davidfowl · 2025-11-14T23:14:24Z

@copilot Lets rename this to GetStepsByTag since it's a string overload.

Renamed the method to be more explicit that it's querying by tag rather than by resource. This makes the API clearer when multiple overloads exist. Updated all usages in tests to use the new method name. Co-authored-by: davidfowl <[email protected]>

Copilot · 2025-11-14T23:21:21Z

@copilot Lets rename this to GetStepsByTag since it's a string overload.

Done in ddc23a1. Renamed GetSteps(string tag) to GetStepsByTag(string tag) and updated all test usages.

captainsafia

@copilot Tweak these tags.

captainsafia · 2025-11-18T22:59:08Z

src/Aspire.Hosting/Pipelines/DistributedApplicationPipeline.cs

        {
            Name = WellKnownPipelineSteps.Deploy,
            Action = _ => Task.CompletedTask,
+            Tags = [WellKnownPipelineTags.DeployCompute]


Suggested change

Tags = [WellKnownPipelineTags.DeployCompute]

captainsafia · 2025-11-18T22:59:32Z

src/Aspire.Hosting/Pipelines/DistributedApplicationPipeline.cs

            Name = WellKnownPipelineSteps.Publish,
-            Action = _ => Task.CompletedTask
+            Action = _ => Task.CompletedTask,
+            Tags = [WellKnownPipelineTags.PushContainerImage]


Suggested change

Tags = [WellKnownPipelineTags.PushContainerImage]

captainsafia · 2025-11-18T22:59:39Z

src/Aspire.Hosting/Pipelines/DistributedApplicationPipeline.cs

        {
            Name = WellKnownPipelineSteps.PublishPrereq,
            Action = _ => Task.CompletedTask,
+            Tags = [WellKnownPipelineTags.PushContainerImage]


Suggested change

Tags = [WellKnownPipelineTags.PushContainerImage]

Removed in d595317. PublishPrereq doesn't push containers, so it shouldn't have the PushContainerImage tag.

Removed tags from Deploy, Publish, and PublishPrereq steps as these are meta/coordination steps that don't actually perform the tagged actions themselves. They coordinate when other steps run. Steps that actually perform actions (like DeployPrereq for provisioning, Build/BuildPrereq for building) still retain their tags. Updated test expectations to verify these meta steps have no tags. Co-authored-by: captainsafia <[email protected]>

Copilot · 2025-11-18T23:07:20Z

@copilot Tweak these tags.

Done in d595317. Removed tags from Deploy, Publish, and PublishPrereq as they are meta/coordination steps that don't actually perform those actions. Only steps that perform actual actions (DeployPrereq for provisioning, Build/BuildPrereq for building) retain tags.

github-actions · 2025-11-18T23:11:39Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12960

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12960"

github-actions · 2025-11-18T23:11:39Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12960

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12960"

Initial plan

538698f

Copilot AI assigned Copilot and captainsafia Nov 14, 2025

Copilot started work on behalf of captainsafia November 14, 2025 00:53 View session

Copilot AI changed the title ~~[WIP] Add tags to default steps in DistributedApplicationPipeline~~ Add WellKnownPipelineTags to default pipeline steps Nov 14, 2025

Copilot AI requested a review from captainsafia November 14, 2025 01:23

Copilot finished work on behalf of captainsafia November 14, 2025 01:23

Copilot started work on behalf of davidfowl November 14, 2025 23:15 View session

Copilot AI changed the title ~~Add WellKnownPipelineTags to default pipeline steps~~ Add WellKnownPipelineTags to default pipeline steps and rename GetSteps to GetStepsByTag Nov 14, 2025

Copilot AI requested a review from davidfowl November 14, 2025 23:23

Copilot finished work on behalf of davidfowl November 14, 2025 23:23

captainsafia reviewed Nov 18, 2025

View reviewed changes

Copilot started work on behalf of captainsafia November 18, 2025 23:00 View session

Copilot AI changed the title ~~Add WellKnownPipelineTags to default pipeline steps and rename GetSteps to GetStepsByTag~~ Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag Nov 18, 2025

Copilot AI requested a review from captainsafia November 18, 2025 23:09

Copilot finished work on behalf of captainsafia November 18, 2025 23:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag #12960

Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag #12960

Copilot AI commented Nov 14, 2025 •

edited

Loading

Uh oh!

davidfowl commented Nov 14, 2025

Uh oh!

Copilot AI commented Nov 14, 2025

Uh oh!

captainsafia left a comment

Uh oh!

captainsafia Nov 18, 2025

Uh oh!

captainsafia Nov 18, 2025

Uh oh!

captainsafia Nov 18, 2025

Uh oh!

Copilot AI Nov 18, 2025

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag #12960

Are you sure you want to change the base?

Add WellKnownPipelineTags to action-performing pipeline steps and rename GetSteps to GetStepsByTag #12960

Conversation

Copilot AI commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

davidfowl commented Nov 14, 2025

Uh oh!

Copilot AI commented Nov 14, 2025

Uh oh!

captainsafia left a comment

Choose a reason for hiding this comment

Uh oh!

captainsafia Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

captainsafia Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

captainsafia Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 14, 2025 •

edited

Loading