Skip to content

Conversation

@askpt
Copy link

@askpt askpt commented Nov 18, 2025

Signed-off-by: André Silva [email protected]

Description

This pull request updates internal documentation links in the docs/contributing.md file to use absolute paths. This ensures that all referenced documents resolve correctly regardless of the current location of the file, improving navigation and reducing broken link issues. I found in the main repository page the links were broken while it was working if you navigate to the docs folder. Example: https://github.com/dotnet/aspire?tab=contributing-ov-file

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13031

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13031"

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 18, 2025
@askpt askpt marked this pull request as ready for review November 18, 2025 16:22
Copilot AI review requested due to automatic review settings November 18, 2025 16:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken documentation links in docs/contributing.md by converting relative paths to absolute paths. When viewing the file from GitHub's repository root (e.g., via the "Contributing" tab), relative links were breaking because they couldn't resolve properly outside the /docs directory context.

Key Changes:

  • Updated all internal documentation links to use absolute paths (e.g., /docs/machine-requirements.md instead of machine-requirements.md)
  • Updated the Components README link to use an absolute path (/src/Components/README.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant