Support Controller suffix in MapControllerRoute

[davidfowl]

This would allow MapControllerRoute to be used with nameof more seamlessly:

Today we have to do something like this:

endpoints.MapControllerRoute("name", "/{**path}", defaults: new
{
    controller = nameof(HomeController).Replace("Controller", ""),
    action = nameof(HomeController.Hello)
});

This would be better:

endpoints.MapControllerRoute("name", "/{**path}", defaults: new
{
    controller = nameof(HomeController),
    action = nameof(HomeController.Hello)
});

[ShreyasJejurkar]

Hi @davidfowl, Seems like changes needed here in this file https://github.com/dotnet/aspnetcore/blob/master/src/Mvc/Mvc.Core/src/Builder/ControllerEndpointRouteBuilderExtensions.cs correct?

I think we need a separate private method there to get actual name of controller, so that we can use nameof for other methods as well like for example MapFallbackToController method.

[davidfowl]

I think it needs to be done in the place that resolves controllers so that it works outside of this one call. I also hate to be weird edge case guy but there's also this:

using System;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Routing;
using Microsoft.AspNetCore.Routing;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;

namespace WebApplication18
{
    public class Startup
    {
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddControllers();

            services.AddSingleton<RouteValueTransformer>();
        }

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }

            app.UseRouting();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapDynamicControllerRoute<RouteValueTransformer>("/{**path}");

                endpoints.MapControllerRoute("name", "/{**path}", defaults: new
                {
                    controller = nameof(HomeControllerController)[0..^10],
                    action = nameof(HomeControllerController.Hello)
                });
            });
        }
    }

    public class RouteValueTransformer : DynamicRouteValueTransformer
    {
        public override ValueTask<RouteValueDictionary> TransformAsync(HttpContext httpContext, RouteValueDictionary values)
        {
            return new ValueTask<RouteValueDictionary>(new RouteValueDictionary
            {
                { "controller", nameof(HomeControllerController)[0..^10] },
                { "action", nameof(HomeControllerController.Hello) },
            });
        }
    }

    public class HomeControllerController : ControllerBase
    {
        public string Hello() => "Hello Controller";
    }
}

This shows 2 cases, a DynamicRouteValueTransformer and using MapControllerRoute directly. In either case, setting route values should resolve to the controller in either case. Also this shows that if I call my controller HomeControllerController, only the last controller suffix is removed (so my original demo was naïve).

[ShreyasJejurkar]

Yeah, I thought the same about that situation where some might put two controller suffix at the end! 😅😅

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.