Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples for aspire standalone only expose 4317 (grpc) and not 4318 (http) #1834

Open
stevesea opened this issue Oct 14, 2024 · 2 comments
Open
Labels
⌚ Not Triaged Not triaged

Comments

@stevesea
Copy link

Describe the issue or suggestion

The otel spec https://github.com/open-telemetry/opentelemetry-specification/blob/v1.28.0/specification/protocol/exporter.md#specify-protocol has changed -- gRPC is no longer the suggested default for SDKs.

SDKs SHOULD support both grpc and http/protobuf transports and MUST support at least one of them. If they support only one, it SHOULD be http/protobuf. They also MAY support http/json.

If no configuration is provided the default transport SHOULD be http/protobuf unless SDKs have good reasons to choose grpc as the default (e.g. for backward compatibility reasons when grpc was already the default in a stable SDK release).

Please update the examples to expose the 4318 port -p 4318:18890

@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Oct 14, 2024
@IEvangelist
Copy link
Member

Flagging @JamesNK for visibility.

@JamesNK
Copy link
Member

JamesNK commented Oct 15, 2024

I think it's fine to have all the dashboard docker run commands expose both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌚ Not Triaged Not triaged
Projects
None yet
Development

No branches or pull requests

3 participants