Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add items to cart without logging in #27

Open
JamesNK opened this issue Nov 1, 2023 · 3 comments · May be fixed by #156
Open

Add items to cart without logging in #27

JamesNK opened this issue Nov 1, 2023 · 3 comments · May be fixed by #156
Labels
good first issue Good for newcomers
Milestone
Backlog

Comments

@JamesNK
Copy link
Member

JamesNK commented Nov 1, 2023

Every online store I've used allows anonymously adding items to a shopping cart and then prompts for login during check out. Unusually, eshop requires logging in before adding items to the cart. I think the demo should follow the usual rules for websites.

Was this done for technical reasons? i.e. tracking cart items against an account, or to show off requiring auth in the cart APIs
@adityamandaleeka adityamandaleeka added this to the Backlog milestone Nov 1, 2023
@adityamandaleeka adityamandaleeka added the good first issue Good for newcomers label Nov 1, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Nov 1, 2023

re: good first issue

I think there are technical and UI implications to making this change. It's probably not simple.

This was referenced Jan 11, 2024
Closed
Open
@ks1990cn
Copy link

ks1990cn commented Jan 11, 2024 •
edited
Loading

Interesting, created a PR. My idea is to store cart into session before log-in. Then we can move that into user bucket when user logs-in.

Any suggestions on this idea?

@sirmarvinc
Copy link

Interesting, created a PR. My idea is to store cart into session before log-in. Then we can move that into user bucket when user logs-in.

Any suggestions on this idea?

I think a browserDB would be a much cleaner way to keep the data for much longer, then clear this when there is login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Support adding items to cart without logging in ks1990cn/eShop
4 participants
@adityamandaleeka @JamesNK @ks1990cn @sirmarvinc