ExecuteUpdate: compare by alias, not by reference (#34601)

Author: ChrisJollyAU

src/EFCore.Relational/Query/QuerySqlGenerator.cs

@@ -1472,7 +1472,7 @@ protected override Expression VisitUpdate(UpdateExpression updateExpression)
                     var table = selectExpression.Tables[i];
                     var joinExpression = table as JoinExpressionBase;
 
-                    if (ReferenceEquals(updateExpression.Table, joinExpression?.Table ?? table))
+                    if (updateExpression.Table.Alias == (joinExpression?.Table.Alias ?? table.Alias))
                     {
                         LiftPredicate(table);
                         continue;

test/EFCore.Sqlite.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesSqliteTest.cs

@@ -63,8 +63,7 @@ public override async Task Delete_aggregate_root_when_table_sharing_with_non_own
 
     public override async Task Replace_ColumnExpression_in_column_setter(bool async)
     {
-        // #33947
-        await Assert.ThrowsAsync<SqliteException>(() => base.Replace_ColumnExpression_in_column_setter(async));
+        await base.Replace_ColumnExpression_in_column_setter(async);
 
         AssertSql(
             """
@@ -73,7 +72,7 @@ public override async Task Replace_ColumnExpression_in_column_setter(bool async)
 UPDATE "OwnedCollection" AS "o0"
 SET "Value" = @p
 FROM "Owner" AS "o"
-INNER JOIN "OwnedCollection" AS "o0" ON "o"."Id" = "o0"."OwnerId"
+WHERE "o"."Id" = "o0"."OwnerId"
 """);
     }