Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming property renames get and set keywords use braking the code #18270

Open
xperiandri opened this issue Jan 26, 2025 · 0 comments
Open

Renaming property renames get and set keywords use braking the code #18270

xperiandri opened this issue Jan 26, 2025 · 0 comments
Labels
Area-LangService-RenameSymbol FCS and VS support for renaming symbols Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@xperiandri
Copy link
Contributor

Please provide a succinct description of the issue.

Repro steps

  1. Create any property
[<Struct>]
type IterationState<'T> = {
    /// A flag to stop the iteration.
    StopRef : bool Ref
} with
    member this.Stop
        with get () = this.StopRef.Value
        and set v = this.StopRef.Value <- v 
  1. Set cursor to Stop
  2. Rename
  3. See
    member this.ShouldStop
        with ShouldStop () = this.StopRef.Value
        and ShouldStop v = this.StopRef.Value <- v
F.property.rename.mp4

Expected behavior

Renamed only the property but not the getter and setter

Actual behavior

Getter and setter are being renamed along with a property

Related information

Provide any related information (optional):

Microsoft Visual Studio Enterprise 2022 (64-bit)
Version 17.12.4

@github-actions github-actions bot added this to the Backlog milestone Jan 26, 2025
@T-Gro T-Gro added Area-LangService-RenameSymbol FCS and VS support for renaming symbols Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Needs-Triage labels Jan 27, 2025
@T-Gro T-Gro modified the milestones: Backlog, January 2025, February 2025 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-RenameSymbol FCS and VS support for renaming symbols Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
Status: New
Development

No branches or pull requests

2 participants