Skip to content

[Windows build perf] Tasks with no inputs should not be executed remotely #19600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
5 tasks
emaf opened this issue Dec 8, 2023 · 4 comments · May be fixed by #22689
Open
5 tasks

[Windows build perf] Tasks with no inputs should not be executed remotely #19600

emaf opened this issue Dec 8, 2023 · 4 comments · May be fixed by #22689
Labels
msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Milestone
.NET 10

Comments

@emaf
Copy link
Contributor

emaf commented Dec 8, 2023 •
edited by rolfbjarne
Loading

Steps to Reproduce

As running tasks remotely adds ~200ms to the execution, we should avoid executing remotely tasks that have no inputs and that won't end up doing anything on the Mac in that case.

There might be more, but these are the ones I've found so far:

  • GetFileSystemEntries when no DirectoryPath was specified
  • FilterStaticFrameworks when no FrameworkToPublish was specified
  • GetFullPaths when Items is empty
  • Copy when SourceFiles is empty
  • CoreMLCompiler when there are no models

Expected Behavior

Actual Behavior

Environment

Version information

Build Logs

Example Project (If Possible)
@emaf emaf added performance If an issue or pull request is related to performance msbuild Issues affecting our msbuild tasks/targets windows-only The issue only occur on Windows labels Dec 8, 2023
@emaf emaf mentioned this issue Dec 8, 2023
Open
16 tasks
@rolfbjarne rolfbjarne added this to the .NET 9 milestone Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Optimizations in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 26, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 26, 2024
@dellis1972
Copy link
Contributor

@emaf I'm taking a look at this issue , any chance you have permission to add me to the repo? I currently cant push to a development branch? Android doesn't work right from forks so we work in the main repo, is that how this repo works?

@emaf
Copy link
Contributor Author

emaf commented Apr 28, 2025

@rolfbjarne could you help @dellis1972 with this?

@rolfbjarne
Copy link
Member

@dellis1972 joining the macios-partners team should do it: https://repos.opensource.microsoft.com/orgs/dotnet/teams/macios-partners

@rolfbjarne
Copy link
Member

And yes, we work from the main repo (in a dev/<user>/<feature> branch), not a fork.

@dellis1972 dellis1972 linked a pull request Apr 29, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
msbuild Issues affecting our msbuild tasks/targets performance If an issue or pull request is related to performance windows-only The issue only occur on Windows
Projects
None yet
Milestone
.NET 10
Development

Successfully merging a pull request may close this issue.

Skip calling certain Tasks if the input is empty dotnet/macios
4 participants
@rolfbjarne @dellis1972 @emaf @samhouts