-
Notifications
You must be signed in to change notification settings - Fork 549
Look for runtime packs in Release instead of Debug for consistency with build-custom-runtime.sh #24342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…th build-custom-runtime.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the custom .NET NuGet feed path to look for runtime packs in the Release artifacts, aligning the Makefile’s behavior with the intended packaging flow and the noted build script consistency. It affects the builds Makefile for scenarios where CUSTOM_DOTNET is set.
- Switch CUSTOM_DOTNET_NUGET_FEED from Debug/Shipping to Release/Shipping
- No functional changes beyond feed source path; improves consistency with the runtime build process
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
✅ [CI Build #eb27363] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #eb27363] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #eb27363] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #eb27363] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #eb27363] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #eb27363] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #eb27363] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #eb27363] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🔥 [CI Build #eb27363] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 4 tests failed, 113 tests passed. Failures❌ monotouch tests (iOS)
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)
Html Report (VSDrops) Download ❌ xcframework tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Fixes #24339 according to the proposed solution.
In summary:
Debugbuild-custom-runtime.sh) usesReleaseRelease, as it was before.Original PR: #24340.