Skip to content

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Dec 1, 2025

Fixes #24339 according to the proposed solution.

In summary:

  • The updated Makefile was the only place where we looked for custom runtime packs under Debug
    • This was introduced recently in f4fb0e8
  • The rest of the code base (e.g. build-custom-runtime.sh) uses Release
  • This PR unifies the paths to use Release, as it was before.

Original PR: #24340.

@rolfbjarne rolfbjarne requested a review from Copilot December 1, 2025 17:45
@rolfbjarne rolfbjarne added the community Community contribution ❤ label Dec 1, 2025
@rolfbjarne rolfbjarne enabled auto-merge (squash) December 1, 2025 17:47
Copilot finished reviewing on behalf of rolfbjarne December 1, 2025 17:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the custom .NET NuGet feed path to look for runtime packs in the Release artifacts, aligning the Makefile’s behavior with the intended packaging flow and the noted build script consistency. It affects the builds Makefile for scenarios where CUSTOM_DOTNET is set.

  • Switch CUSTOM_DOTNET_NUGET_FEED from Debug/Shipping to Release/Shipping
  • No functional changes beyond feed source path; improves consistency with the runtime build process

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@rolfbjarne rolfbjarne disabled auto-merge December 1, 2025 17:47
@rolfbjarne rolfbjarne enabled auto-merge (squash) December 1, 2025 17:48
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #eb27363] Build passed (Build packages) ✅

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #eb27363] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #eb27363] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #eb27363] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #eb27363] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #eb27363] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #eb27363] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #eb27363] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #eb27363] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 4 tests failed, 113 tests passed.

Failures

❌ monotouch tests (iOS)

1 tests failed, 8 tests passed.
  • monotouch-test/iOS - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

1 tests failed, 10 tests passed.
  • monotouch-test/Mac Catalyst/Release (static registrar, all optimizations): Failed (Test run failed.
    Tests run: 3438 Passed: 3206 Inconclusive: 13 Failed: 1 Ignored: 231)

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

1 tests failed, 8 tests passed.
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

❌ xcframework tests

1 tests failed, 3 tests passed.
  • xcframework-test/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: eb27363752c77deb1853c84a752d1012b12505d8 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution ❤

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong path for custom runtime packs

4 participants