You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+23-22
Original file line number
Diff line number
Diff line change
@@ -19,9 +19,9 @@ If you can't find an existing issue, log a new issue in this GitHub repository.
19
19
-**DO** use a descriptive title that identifies the issue to be addressed or the requested feature. For example, when describing an issue where the compiler is not behaving as expected, write your bug title in terms of what the compiler should do rather than what it is doing – “C# compiler should report CS1234 when Xyz is used in Abcd.”
20
20
-**DO** specify a detailed description of the issue or requested feature.
21
21
-**DO** provide the following for bug reports
22
-
- Describe the expected behavior and the actual behavior. If it is not self-evident such as in the case of a crash, provide an explanation for why the expected behavior is expected.
23
-
- Provide example code that reproduces the issue.
24
-
- Specify any relevant exception messages and stack traces.
22
+
- Describe the expected behavior and the actual behavior. If it is not self-evident such as in the case of a crash, provide an explanation for why the expected behavior is expected.
23
+
- Provide example code that reproduces the issue.
24
+
- Specify any relevant exception messages and stack traces.
25
25
-**DO** subscribe to notifications for the created issue in case there are any follow up questions.
26
26
27
27
## Reporting security issues and bugs
@@ -40,18 +40,17 @@ Security issues and bugs should be reported privately, via email, to the Microso
40
40
41
41
If you would like to make a contribution to an area not documented here, first open an issue with a description of the change you would like to make and the problem it solves so it can be discussed before a pull request is submitted.
42
42
43
-
44
43
### Resources to help you get started
45
44
46
45
Here are some resources to help you get started on how to contribute code or new content.
47
46
48
-
* Look at the [Contributor documentation](https://github.com/dotnet/roslyn/blob/main/docs/contributing/Building%2C%20Debugging%2C%20and%20Testing%20on%20Windows.md) to get started on building the source code on your own.
49
-
* Finding a bug to fix in the [IDE](https://aka.ms/roslyn-ide-bugs-help-wanted) or [Compiler](https://aka.ms/roslyn-compiler-bugs-help-wanted)
50
-
* Finding a feature to implement in the [IDE](https://aka.ms/roslyn-ide-feature-help-wanted) or [Compiler](https://aka.ms/roslyn-compiler-feature-help-wanted)
47
+
- Look at the [Contributor documentation](https://github.com/dotnet/roslyn/blob/main/docs/contributing/Building%2C%20Debugging%2C%20and%20Testing%20on%20Windows.md) to get started on building the source code on your own.
48
+
- Finding a bug to fix in the [IDE](https://aka.ms/roslyn-ide-bugs-help-wanted) or [Compiler](https://aka.ms/roslyn-compiler-bugs-help-wanted)
49
+
- Finding a feature to implement in the [IDE](https://aka.ms/roslyn-ide-feature-help-wanted) or [Compiler](https://aka.ms/roslyn-compiler-feature-help-wanted)
51
50
52
51
### Identifying the scale
53
52
54
-
If you would like to contribute to one of our repositories, first identify the scale of what you would like to contribute. If it is small (grammar/spelling or a bug fix) feel free to start working on a fix.
53
+
If you would like to contribute to one of our repositories, first identify the scale of what you would like to contribute. If it is small (grammar/spelling or a bug fix) feel free to start working on a fix.
55
54
56
55
If you are submitting a feature or substantial code contribution, please discuss it with the team and ensure it follows the product roadmap.
57
56
You might also read these two blogs posts on contributing code: [Open Source Contribution Etiquette](http://tirania.org/blog/archive/2010/Dec-31.html) by Miguel de Icaza and [Don't "Push" Your Pull Requests](https://www.igvita.com/2011/12/19/dont-push-your-pull-requests/) by Ilya Grigorik.
@@ -60,7 +59,7 @@ All code submissions will be rigorously reviewed and tested further by the Rosly
60
59
61
60
### Before writing code
62
61
63
-
To file a API proposal, look for the relevant issue in the `New issue` page or simply click [this link](https://github.com/dotnet/roslyn/issues/new?assignees=&labels=Feature+Request%2CConcept-API&projects=&template=api-suggestion.md), as part of the [API review process](<docs/contributing/API Review Process.md>).
62
+
To file a API proposal, look for the relevant issue in the `New issue` page or simply click [this link](https://github.com/dotnet/roslyn/issues/new?assignees=&labels=Feature+Request%2CConcept-API&projects=&template=api-suggestion.md), as part of the [API review process](<docs/contributing/API Review Process.md>).
64
63
65
64
## Coding Style
66
65
@@ -80,16 +79,17 @@ if (argument == null)
80
79
81
80
-**DO** use `Debug.Assert()` for checks not needed in release builds. Always include a “message” string in your assert to identify failure conditions. Add assertions to document assumptions on non-local program state or parameter values, e.g. “At this point in parsing the scanner should have been advanced to a ‘.’ token by the caller”.
82
81
-**DO** avoid allocations in compiler hot paths:
83
-
- Avoid LINQ.
84
-
- Avoid using `foreach` over collections that do not have a `struct` enumerator.
85
-
- Consider using an object pool. There are many usages of object pools in the compiler to see an example.
82
+
- Avoid LINQ.
83
+
- Avoid using `foreach` over collections that do not have a `struct` enumerator.
84
+
- Consider using an object pool. There are many usages of object pools in the compiler to see an example.
86
85
87
86
### Visual Basic Conventions
88
87
89
88
-**DO** apply the spirit of C# guidelines to Visual Basic when there are natural analogs.
90
89
-**DO** place all field declarations at the beginning of a type definition
91
90
92
91
### Tips 'n' Tricks
92
+
93
93
Our team finds using [this enhanced source view](http://sourceroslyn.io/) of Roslyn helpful when developing.
94
94
95
95
## How to submit a PR
@@ -101,19 +101,19 @@ To help you be successful we've put together a few simple rules to follow when y
101
101
102
102
Before submitting a pull request, make sure that it checks the following requirements:
103
103
104
-
* You find an existing issue with the "help-wanted" label or discuss with the team to agree on adding a new issue with that label
105
-
* You post a high-level description of how it will be implemented and receive a positive acknowledgement from the team before getting too committed to the approach or investing too much effort in implementing it.
106
-
* You add test coverage following existing patterns within the codebase
107
-
* Your code matches the existing syntax conventions within the codebase
108
-
* Your PR is small, focused, and avoids making unrelated changes
104
+
- You find an existing issue with the "help-wanted" label or discuss with the team to agree on adding a new issue with that label
105
+
- You post a high-level description of how it will be implemented and receive a positive acknowledgement from the team before getting too committed to the approach or investing too much effort in implementing it.
106
+
- You add test coverage following existing patterns within the codebase
107
+
- Your code matches the existing syntax conventions within the codebase
108
+
- Your PR is small, focused, and avoids making unrelated changes
109
109
110
110
If your pull request contains any of the below, it's less likely to be merged.
111
111
112
-
* Changes that break backward compatibility
113
-
* Changes that are only wanted by one person/company. Changes need to benefit a large enough proportion of Roslyn developers.
114
-
* Changes that add entirely new feature areas without prior agreement
115
-
* Changes that are mostly about refactoring existing code or code style
116
-
* Very large PRs that would take hours to review (remember, we're trying to help lots of people at once). For larger work areas, please discuss with us to find ways of breaking it down into smaller, incremental pieces that can go into separate PRs.
112
+
- Changes that break backward compatibility
113
+
- Changes that are only wanted by one person/company. Changes need to benefit a large enough proportion of Roslyn developers.
114
+
- Changes that add entirely new feature areas without prior agreement
115
+
- Changes that are mostly about refactoring existing code or code style
116
+
- Very large PRs that would take hours to review (remember, we're trying to help lots of people at once). For larger work areas, please discuss with us to find ways of breaking it down into smaller, incremental pieces that can go into separate PRs.
117
117
118
118
### Submitting a pull request
119
119
@@ -146,6 +146,7 @@ Your pull request will now go through extensive checks by the subject matter exp
146
146
A core contributor will review your pull request and provide feedback.
147
147
148
148
### Automatic repo rules
149
+
149
150
To ensure that there is not a large backlog of inactive PRs, the pull request will be marked as stale after two weeks of no activity. After another two weeks, it will be reset to 'Draft' state.
0 commit comments