Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64-SVE: Separate operand and mask generation in test templates #104804

Open
amanasifkhalid opened this issue Jul 12, 2024 · 1 comment
Open

ARM64-SVE: Separate operand and mask generation in test templates #104804

amanasifkhalid opened this issue Jul 12, 2024 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support Priority:3 Work that is nice to have
Milestone
Future

Comments

@amanasifkhalid
Copy link
Member

Some of the SVE test templates, such as SveVecBinOpVecTest, use the NextValueOp1 template variable for generating both op1 and mask inputs. If we use Helpers.getMask* to generate the mask input, this artificially constrains the possible values for op1 (i.e. just binary inputs). We should separate the logic for generating the mask value out into its own template variable, like NextValueMask. comment
@amanasifkhalid amanasifkhalid added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 12, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@amanasifkhalid amanasifkhalid mentioned this issue Jul 12, 2024
Merged
@amanasifkhalid amanasifkhalid added this to the Future milestone Jul 12, 2024
@amanasifkhalid amanasifkhalid removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 12, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this issue Jul 15, 2024
Merged
@kunalspathak kunalspathak added the Priority:3 Work that is nice to have label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support Priority:3 Work that is nice to have
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@jeffschwMSFT @kunalspathak @amanasifkhalid