Make Async Profiler tests compatible with single threaded runtime. by lateralusX · Pull Request #127762 · dotnet/runtime

lateralusX · 2026-05-04T15:20:46Z

Initial async profiler tests used some techniques to isolate tests running on thread pool, but that doesn't work on single threaded platforms like WASM.

Split tests into tests that can run without multithreaded support and tests that must have thread pool.
Harden test to only look for specific events using a Task id mapping to the marker frame used by the test.
Fix failures on Native AOT due to missing native IP -> Method Name.

With these changes we now have all tests running on CoreCLR, NativeAOT and 38 out of 48 tests running on CoreCLR WASM single threaded configuration.

Copilot

Copilot wasn't able to review any files in this pull request.

dotnet-policy-service · 2026-05-04T15:22:09Z

Tagging subscribers to this area: @JulieLeeMSFT, @VSadov
See info in area-owners.md if you want to be subscribed.

lateralusX · 2026-05-05T17:35:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-05-05T17:35:23Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

lateralusX · 2026-05-12T13:54:54Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-05-12T13:55:15Z

Azure Pipelines successfully started running 1 pipeline(s).

lateralusX · 2026-05-12T18:54:14Z

@MichalStrehovsky, I fixed up the async profiler tests in this PR and ran all on the NAOT outertloop pipeline, looking at the failure, they seem to be unrelated. Anything else that needs to be run from a NAOT perspective or all good?

MichalStrehovsky · 2026-05-13T01:59:01Z

@MichalStrehovsky, I fixed up the async profiler tests in this PR and ran all on the NAOT outertloop pipeline, looking at the failure, they seem to be unrelated. Anything else that needs to be run from a NAOT perspective or all good?

If these pass in runtime-nativeaot-outerloop, then LGTM! Thank you!

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

lateralusX · 2026-05-13T11:22:01Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2026-05-13T11:22:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2026-05-13T14:01:16Z

-                            int maxDynamicEventPayloadSize = wrapperIPs.Length * Serializer.MaxCompressedUInt64Size;
+                            // [wrapperNameTemplateLength (compressed uint32)]
+                            // [wrapperNameTemplate UTF8 bytes]
+                            ReadOnlySpan<byte> templateBytes = ContinuationWrapper.NameTemplateUtf8;


Do you expect the names of the wrappers to change? Can the names of wrappers be part of the async profiler contract instead of sending a constant string in each metadata payload? It is common for diagnostic tools to have hardcoded managed type and method names.

Probably not, but added it to have the flexibility since it felt bad to enforce the assumption as part of the contract, the metadata event is only emitted once per profiler session, so cheap.

Copilot AI review requested due to automatic review settings May 4, 2026 15:20

Copilot AI reviewed May 4, 2026

View reviewed changes

github-actions Bot added the area-System.Threading label May 4, 2026

lateralusX mentioned this pull request May 4, 2026

Enable EventSource in System.Threading.Tasks.Tests #127744

Merged

dotnet-policy-service Bot assigned lateralusX May 4, 2026

lateralusX marked this pull request as draft May 4, 2026 15:54

build-analysis Bot mentioned this pull request May 4, 2026

XHarness package install failure on iOS due to devicectl NSPOSIXErrorDomain error 49 #123796

Open

lateralusX added 5 commits May 5, 2026 13:34

Make Async Profiler tests compatible with single threaded runtime.

443d505

Fix Native AOT async profiler tests.

0801ade

Reenable async profiler Native AOT tests.

c38560d

Change wrapper table from IP to method name template.

d53bfa0

Enable additional diagnostics for specific async profiler tests.

fe86a97

lateralusX force-pushed the lateralusX/async-profiler-test-adjustments branch from b3a77ba to fe86a97 Compare May 5, 2026 16:47

Harden callstack depth match tests to work on WASM.

079fe13

build-analysis Bot mentioned this pull request May 5, 2026

[Test Failure] WinHTTP: PlatformHandlerTest_Cookies_Http2.GetAsync_ReceiveSetCookieHeader_CookieAdded #126867

Open

Copilot AI review requested due to automatic review settings May 6, 2026 07:56

Copilot started reviewing on behalf of lateralusX May 6, 2026 07:57 View session

lateralusX marked this pull request as ready for review May 6, 2026 08:01

Copilot AI reviewed May 6, 2026

View reviewed changes

lateralusX added 3 commits May 6, 2026 11:39

Review feedback.

5a19b71

Remove some unneeded lambas + fix xunit sync context.

3c7ba4b

Enable some diagnostics for two WASM tests.

1b066eb

This was referenced May 6, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

lateralusX commented May 6, 2026

View reviewed changes

Comment thread ...ime/tests/System.Threading.Tasks.Tests/System.Runtime.CompilerServices/AsyncProfilerTests.cs

Remove diagnostics from specific async profiler tests.

f326b98

Copilot AI review requested due to automatic review settings May 6, 2026 14:21

Copilot AI reviewed May 6, 2026

View reviewed changes

lateralusX mentioned this pull request May 6, 2026

[ci-scan] Known Build Error: AsyncProfilerTests.RuntimeAsync_CallstackSimulation fails in runtime-nativeaot-outerloop on osx-arm #127856

Open

lateralusX added 2 commits May 11, 2026 12:30

Review feedback.

a7425fe

Fix RuntimeAsync_CreateCallstackPrecedesResumeCallstack on WASM.

191fa84

Copilot AI review requested due to automatic review settings May 12, 2026 09:29

Copilot started reviewing on behalf of lateralusX May 12, 2026 09:30 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

build-analysis Bot mentioned this pull request May 12, 2026

Mono WASM test failure with "MONO_WASM: Unhandled error: TypeError: Failed to fetch" #127424

Open

build-analysis Bot mentioned this pull request May 12, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

MichalStrehovsky reviewed May 13, 2026

View reviewed changes

Comment thread ...ime/tests/System.Threading.Tasks.Tests/System.Runtime.CompilerServices/AsyncProfilerTests.cs Outdated

Remove old comment.

d9b62e5

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 06:48

Copilot started reviewing on behalf of lateralusX May 13, 2026 06:48 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Remove unused function in test.

37b88c2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 13, 2026 07:11

Copilot started reviewing on behalf of lateralusX May 13, 2026 07:11 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncProfiler.cs

jkotas reviewed May 13, 2026

View reviewed changes

build-analysis Bot mentioned this pull request May 13, 2026

[ci-scan] Known Build Error: NullReferenceException in AsyncHelpers.RuntimeAsyncTask.HandleSuspended on NativeAOT x86 #127900

Open

Conversation

lateralusX commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

dotnet-policy-service Bot commented May 4, 2026

Uh oh!

lateralusX commented May 5, 2026

Uh oh!

azure-pipelines Bot commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lateralusX commented May 12, 2026

Uh oh!

azure-pipelines Bot commented May 12, 2026

Uh oh!

lateralusX commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MichalStrehovsky commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

lateralusX commented May 13, 2026

Uh oh!

azure-pipelines Bot commented May 13, 2026

Uh oh!

jkotas May 13, 2026

Choose a reason for hiding this comment

Uh oh!

lateralusX May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lateralusX commented May 4, 2026 •

edited

Loading

lateralusX commented May 12, 2026 •

edited

Loading